From: Beat Bolli <dev+git@drbeat.li>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff Hostetler <jeffhost@microsoft.com>,
Neeraj Singh <neerajsi@microsoft.com>,
Calvin Wan <calvinwan@google.com>, Victoria Dye <vdye@github.com>
Subject: Re: [PATCH v2 2/2] wrapper: use trace2 counters to collect fsync stats
Date: Wed, 26 Jul 2023 01:03:54 +0200 [thread overview]
Message-ID: <2f39e481-84d1-097c-ec47-5357dbc36798@drbeat.li> (raw)
In-Reply-To: <xmqqo7jzlrdq.fsf@gitster.g>
On 25.07.23 21:31, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> I also spotted this change since v1:
>>
>> - Rename trace2 counters to use "-" (not "_") as inter-word separators.
>>
>> Since I do not seem to be able to find any review comments regarding
>> the variable naming in the v1's thread, let's ask stakeholders.
>>
>> Are folks involved in the trace2 subsystem (especially Jeff
>> Hostetler---already CC:ed---who presumably has the most stake in it)
>> OK with the naming convention of the multi-word variable? This is
>> the first use of multi-word variable name in tr2_ctr, and thus will
>> establish whatever convention you guys want to use. I do have a
>> slight preference of "writeout-only" over "writeout_only" but that
>> is purely from visual appearance. If there is a desire to keep the
>> names literally reusable as identifiers in some languages used to
>> postprocess trace output, or something, that might weigh
>> differently.
>
> I heard absolutely nothing since I asked the above question last
> week, so I'll take the absense of response as absense of interest in
> the way how names are spelled.
>
> Therefore, let me make a unilateral declaration here ;-) The trace2
> counters with multi-word names are to be named using "-" as their
> inter-word separators. Any patch that adds new counters that do not
> follow the convention will silently dropped on the floor from now on.
>
> Let's move this patch forward by merging to 'next' soonish.
Works for me :-)
Cheers!
next prev parent reply other threads:[~2023-07-25 23:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-19 23:24 [PATCH 1/2] trace2: fix a comment Beat Bolli
2023-07-19 23:24 ` [PATCH 2/2] wrapper: use trace2 counters to collect fsync stats Beat Bolli
2023-07-20 0:12 ` Junio C Hamano
2023-07-20 16:48 ` [PATCH v2 " Beat Bolli
2023-07-20 19:26 ` Junio C Hamano
2023-07-25 19:31 ` Junio C Hamano
2023-07-25 23:03 ` Beat Bolli [this message]
2023-08-07 18:25 ` Jeff Hostetler
2023-08-07 18:23 ` Jeff Hostetler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f39e481-84d1-097c-ec47-5357dbc36798@drbeat.li \
--to=dev+git@drbeat.li \
--cc=calvinwan@google.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jeffhost@microsoft.com \
--cc=neerajsi@microsoft.com \
--cc=vdye@github.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).