From: "Dotan Barak" <dotanba@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Rename dynamic memory allocation functions to their "x" version
Date: Wed, 10 Sep 2008 09:02:04 +0300 [thread overview]
Message-ID: <2f3bf9a60809092302u1b8616e6pee3c54003896671c@mail.gmail.com> (raw)
In-Reply-To: <7vprnczlkx.fsf@gitster.siamese.dyndns.org>
On Wed, Sep 10, 2008 at 7:11 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Dotan Barak <dotanba@gmail.com> writes:
>
>> In places that the standard malloc/strdup is used without checking
>> if the allocation was successful, I replaced it to xmalloc/xstrdup
>> which check the memory allocation result.
>>
>> Signed-off-by: Dotan Barak <dotanba@gmail.com>
>
> Looks good. Will apply, but I'd retitle it (it is not "rename").
>
Yes, you are right, i guess "replace" is better ...
Next time..
;)
Dotan
> Thanks.
>
>
prev parent reply other threads:[~2008-09-10 6:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-09 18:57 [PATCH] Rename dynamic memory allocation functions to their "x" version Dotan Barak
2008-09-10 4:11 ` Junio C Hamano
2008-09-10 6:02 ` Dotan Barak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2f3bf9a60809092302u1b8616e6pee3c54003896671c@mail.gmail.com \
--to=dotanba@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).