Re: [PATCH/RFC] add git credential login to remote mediawiki

[roucherj <roucherj@telesun.imag.fr>]

On Tue, 12 Jun 2012 16:51:18 +0200, Matthieu Moy wrote:
> Javier.Roucher-Iglesias@ensimag.imag.fr writes:
>
>>  # MediaWiki API instance, created lazily.
>> +sub run_credential {
>
> How is the code related to the comment right above?
>

Sorry a old comment, i think it's a cause of git rebase i will erase.

>> +	my $Prog = "git credential $op";
>> +	open2 (*Reader, *Writer, $Prog);
>> +	print Writer $msg;
>> +	close (Writer);
>
> No space before "(" for function calls (already mentionned twice).
>

sorry but before it's like:
+	my $Prog = "git credential $op";
+	open2(*Reader, *Writer, $Prog);
+	print Writer $msg;
+	close(Writer);

i have add one space, but the have to be like that?:
+	my $Prog = "git credential $op";
+	open2 ( *Reader, *Writer, $Prog );
+	print Writer $msg;
+	close ( Writer );

>>  my $mediawiki;
>
> Didn't I already mention (twice?) that this declaration was meant to
> stay right above mw_connect_maybe?
>

yes but 'ask_credential' used $mediawiki then i think i have to declare 
before 'ask_credential'

>> +			run_credential("reject");
>> +#			exit 1;
>
> Do you, or do you not want to "exit 1". Either remove this, or 
> uncomment
> it.
>

i have comment this line to see the opinion of the community, because i 
ask all the time to authenticate
but there are few operations who we don't have to authenticate it.

now if we comment this line the login will fail but they will continue 
with the operation (like, git clone)
and try to do it, if the wiki need to be authenticate will refuse the 
operation if not they will continue.

>>  sub mw_connect_maybe {
>> +
>>  	if ($mediawiki) {
>
> Why do you add this blank line? (already mentionned)
>

because we need the structure $mediawiki to get the url if is not 
declare it will return with out doing the operation

>> -	if ($wiki_login) {
>> -		if (!$mediawiki->login({
>> -			lgname => $wiki_login,
>> -			lgpassword => $wiki_passwd,
>> -			lgdomain => $wiki_domain,
>> -		})) {
>> -			print STDERR "Failed to log in mediawiki user \"$wiki_login\" on 
>> $url\n";
>> -			print STDERR "(error " .
>> -			    $mediawiki->{error}->{code} . ': ' .
>> -			    $mediawiki->{error}->{details} . ")\n";
>> -			exit 1;
>> -		} else {
>> -			print STDERR "Logged in with user \"$wiki_login\".\n";
>> -		}
>> -	}
>> +	ask_credential();
>
> This means you can't use the wiki anonymously anymore. This is an
> unacceptable regression.

yes you can use anonymously but login will fail and try to the 
operation, this is the reason because i have comment the 'exit 1'.