git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Mark Levedahl" <mlevedahl@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>,
	"Karl Hasselström" <kha@treskal.com>,
	"Paul Mackerras" <paulus@samba.org>
Subject: Commit 140b378d07229e breaks gitk highlighting
Date: Tue, 9 Sep 2008 08:31:19 -0400	[thread overview]
Message-ID: <30e4a070809090531i6c6dd2c8r189e70927b5444c9@mail.gmail.com> (raw)

gitk since the above commit ("Teach git diff-tree --stdin to diff
trees") fails to reliably highlight commits matching a given path
specification. For an example of the problem,

   $gitk ec3a4ba519c001

   and select commit "touching paths" with "t" in the entry bar

The 4'th commit down (t9124: clean up chdir usage) is NOT highlighted,
though it clearly touches t. Reverting commit 140b378 restores the
correct behavior. This gets into parts of the code I don't understand,
so I decline to try to offer a patch.

Mark

             reply	other threads:[~2008-09-09 12:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-09 12:31 Mark Levedahl [this message]
2008-09-10 16:01 ` Commit 140b378d07229e breaks gitk highlighting Karl Hasselström
2008-09-10 19:22 ` Junio C Hamano
2008-09-10 20:03   ` Mark Levedahl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30e4a070809090531i6c6dd2c8r189e70927b5444c9@mail.gmail.com \
    --to=mlevedahl@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=kha@treskal.com \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).