From: Dragan Simic <dsimic@manjaro.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] doc: add shortcut to "am --whitespace=<action>"
Date: Wed, 14 Feb 2024 20:20:02 +0100 [thread overview]
Message-ID: <31285decfdd9390cfea5cfdd558dbbed@manjaro.org> (raw)
In-Reply-To: <xmqqle7mvp4x.fsf@gitster.g>
On 2024-02-14 20:09, Junio C Hamano wrote:
> Dragan Simic <dsimic@manjaro.org> writes:
>
>>> @@ -128,6 +128,9 @@ include::rerere-options.txt[]
>>> These flags are passed to the 'git apply' (see
>>> linkgit:git-apply[1])
>>> program that applies
>>> the patch.
>>
>> It would be nice to, while there, move "the patch." to the line above.
>
> It belongs to a separate topic. These files are sources that will
> be line filled by AsciiDoc, so there is no reason to make such a
> change unless the topic of your change were to make the source
> "prettier", which is not the focus of this patch. Having such a
> change in the same patch will be distracting.
Makes sense, it can become distracting, especially in a short patch
like this one. It's better to stick to the patch topic, and leave
small cleanups to a separate patch.
prev parent reply other threads:[~2024-02-14 19:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-14 18:44 [PATCH] doc: add shortcut to "am --whitespace=<action>" Junio C Hamano
2024-02-14 19:01 ` Dragan Simic
2024-02-14 19:03 ` Dragan Simic
2024-02-14 19:09 ` Junio C Hamano
2024-02-14 19:20 ` Dragan Simic [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=31285decfdd9390cfea5cfdd558dbbed@manjaro.org \
--to=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).