git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nigel Magnay <nigel.magnay@gmail.com>
To: Robin Rosenberg <robin.rosenberg.lists@dewire.com>
Cc: Git ML <git@vger.kernel.org>, "Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH JGIT] Minor : Make ObjectId, RemoteConfig Serializable
Date: Sun, 8 Feb 2009 13:26:19 +0000	[thread overview]
Message-ID: <320075ff0902080526g2bee8188g395397b06a0c80ee@mail.gmail.com> (raw)
In-Reply-To: <200902080313.21785.robin.rosenberg.lists@dewire.com>

> A problem (big problem) with serialization is that it often leads to
> fragile interfaces. One might want to have precise control over
> the serialization so a change in the implementation doesn't affect
> compatibility. Serializing AnyObjectId should not depend on the
> implementation de jour. Second, how do we handle subclasses?
>
> But maybe leaving it this way would be our way of saying that
> the interface may break at any time, promise.
>


Well, we can of course implement writeObject / readObject (or do so
if/when compatibility breaks, and it's cared about)

That's how I tend to view it anyway (may break at any time) - you
can't just update a jar library to a significantly new version and
expect it all to stay compatible. Also for half my use, it's not for
persistence, it's for transferring over the wire to a slave process.

Thinking a bit more clearly, I probably don't need AnyObjectId, just
ObjectId - but I've also missed RefSpec and URIish as they're used in
RemoteConfig..

  reply	other threads:[~2009-02-08 13:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <320075ff0902060702n7573aaecu9054626ee9a6991@mail.gmail.com>
2009-02-06 21:15 ` [PATCH JGIT] Minor : Make ObjectId, RemoteConfig Serializable Nigel Magnay
2009-02-08  2:13   ` Robin Rosenberg
2009-02-08 13:26     ` Nigel Magnay [this message]
2009-02-08 19:10       ` Shawn O. Pearce
2009-02-08 19:45         ` Robin Rosenberg
2009-02-08 19:47           ` Shawn O. Pearce

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=320075ff0902080526g2bee8188g395397b06a0c80ee@mail.gmail.com \
    --to=nigel.magnay@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=robin.rosenberg.lists@dewire.com \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).