From: Nigel Magnay <nigel.magnay@gmail.com>
To: Git ML <git@vger.kernel.org>
Subject: Re: [JGIT PATCH] 1/2 : (reworked) Externalizable/Serializable Items
Date: Fri, 20 Feb 2009 09:28:38 +0000 [thread overview]
Message-ID: <320075ff0902200128o6b9772a4tcbd652e7654524e@mail.gmail.com> (raw)
In-Reply-To: <320075ff0902200127m3e516621m60a608bc891ab992@mail.gmail.com>
On Wed, Feb 18, 2009 at 4:30 PM, Shawn O. Pearce <spearce@spearce.org> wrote:
>
> Nigel Magnay <nigel.magnay@gmail.com> wrote:
> > +public class ObjectId extends AnyObjectId implements Serializable {
>
> We should define our own serialVersionUID:
>
> private static final long serialVersionUID = 1L;
>
> is good enough to make Java happy.
I'll re-roll. Actually both that and the whitespace damage I'm
partially blaming on eclipse. Eclipse curiously removes the warning to
declare serialVersionUID if you declare both writeObject and
readObject - that's wrong!
Also the formatting came from
.settings/org.eclipse.core.resources.prefs which has a tab policy of
"Tabs only" which has overridden my environment setting of
spaces-only.
I can modify it to spaces only - but the comment in 9268ced9d38 talks
about spaces-per-tab..?
next prev parent reply other threads:[~2009-02-20 9:35 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-16 20:12 [JGIT PATCH] 1/2 : (reworked) Externalizable/Serializable Items Nigel Magnay
2009-02-16 20:16 ` Johannes Schindelin
2009-02-18 16:30 ` Shawn O. Pearce
2009-02-18 20:59 ` Robin Rosenberg
2009-02-18 21:48 ` Shawn O. Pearce
2009-02-18 22:19 ` Sverre Rabbelier
2009-02-18 23:21 ` Robin Rosenberg
2009-02-18 23:27 ` Shawn O. Pearce
[not found] ` <320075ff0902200127m3e516621m60a608bc891ab992@mail.gmail.com>
2009-02-20 9:28 ` Nigel Magnay [this message]
2009-02-20 20:32 ` Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=320075ff0902200128o6b9772a4tcbd652e7654524e@mail.gmail.com \
--to=nigel.magnay@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).