From: "Fabian Pottbäcker" <fpottbaecker+git@mailbox.org>
To: Ben Knoble <ben.knoble@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Patrick Steinhardt <ps@pks.im>
Subject: Re: [PATCH 1/3] urlmatch: normalize ssh and ftp default ports
Date: Tue, 28 Jul 2026 12:51:18 +0200 [thread overview]
Message-ID: <32323233-CE82-421A-94D2-5902C4382F8D@mailbox.org> (raw)
In-Reply-To: <DE62DFBE-ED4C-4EF5-8F4D-FAAB3519F86A@gmail.com>
> On 24. Jul 2026, at 13:35, Ben Knoble <ben.knoble@gmail.com> wrote:
>
> Just offhand, not commenting on the rest of the series : the comments look wrong for ftp, ssh to me.
Right, I messed up the continuation indent here (I wanted to make it in line with the rest of the file).
Lined up for a v2, but it is minor so I would await further comments for now (see https://gitlab.com/fpottbaecker/git/-/compare/config_url_scp_syntax_v1..config_url_scp_syntax).
Also, since I noticed this as a convenience thing gitgitgadget does:
Fetch-It-Via: git fetch https://gitlab.com/fpottbaecker/git.git config_url_scp_syntax_v1
next prev parent reply other threads:[~2026-07-28 10:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 0:40 [PATCH 0/3] config: support scp-style --url Fabian Pottbäcker
2026-07-24 0:40 ` [PATCH 1/3] urlmatch: normalize ssh and ftp default ports Fabian Pottbäcker
2026-07-24 11:35 ` Ben Knoble
2026-07-28 10:51 ` Fabian Pottbäcker [this message]
2026-07-24 0:40 ` [PATCH 2/3] t1300: cover --url for some --get-urlmatch tests Fabian Pottbäcker
2026-07-24 0:40 ` [PATCH 3/3] config: use url_parse for --url Fabian Pottbäcker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32323233-CE82-421A-94D2-5902C4382F8D@mailbox.org \
--to=fpottbaecker+git@mailbox.org \
--cc=ben.knoble@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).