git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Avery Pennarun" <apenwarr@gmail.com>
To: "Roman Shaposhnik" <rvs@sun.com>
Cc: stuart.freeman@et.gatech.edu, git@vger.kernel.org
Subject: Re: Migrating svn to git with heavy use of externals
Date: Tue, 8 Apr 2008 23:33:49 -0400	[thread overview]
Message-ID: <32541b130804082033q55c795b5ieaa4e120956ff030@mail.gmail.com> (raw)
In-Reply-To: <8FE3B7A7-4C2D-4202-A5FC-EBC4F4670273@sun.com>

On Tue, Apr 8, 2008 at 11:03 PM, Roman Shaposhnik <rvs@sun.com> wrote:
> On Apr 8, 2008, at 2:01 PM, Avery Pennarun wrote:
> > The way to understand git-submodule's operation is in terms of what it
> > actually does.  Roughly speaking, git-submodule-add puts things into
> > .gitmodules and .git/config;
>
>  I could be mistaken, but I don't think "git submodule add" does anything
>  to the .git/config. In fact, how settings migrate between .gitmodules
>  and .git/config has been a long standing source of slight confusion
>  for me.
>
>  Please correct me if I'm wrong, but it seems that the only reason
>  for the file .gitmodules to be there at all is because it can be
>  revved through commits, just as any file under Git's control.
>  .git/config doesn't have such a property. Other than that, it is not
>  really needed, right?

You have the last paragraph right, but I think the first paragraph wrong :)

.gitmodules doesn't do anything unless git-submodule reads it, which
it does in git-submodule-init and git-submodule-add.  (You know
git-submodule-add is screwing with .git/config because you don't need
to call git-submodule-init when you use it.)  git-submodule-update,
AFAICT, just reads .git/config.

>  Speaking of complications, it took me awhile to realize that 90%
>  of the Submodule magic seems to be based on the secret ability of
>  tree objects to hold references not only to blobs and trees but
>  also to *commits*:

Indeed, this is the majority of the coolness right there.  The rest of
the screwiness with .gitmodules and so on is really just to support
fetching the objects for the submodules from repos than the primary
supermodule one.

Also, git-checkout seems to explicitly *not* checkout refs to commits
by itself; you have to call git-submodule-update for that.  This is
probably because git-checkout wouldn't know what to do if the
submodule were dirty (ie. the sub-checkout couldn't complete because
files had been changed but not checked in).  This is useful in a
not-destroying-my-data way, but the behaviour isn't too obvious or
coherent.

>  That's exactly what makes me doubtful about .gitmodules being the
>  best place for storing the url, but then again, I don't have any
>  better ideas. :-( Yet ;-)

There's definitely no better place; .git/config isn't versioned, and
URLs don't belong in the tree objects themselves, which are otherwise
location-neutral and transport-neutral.

In my own use case, I think having all the objects from the
supermodule *and* submodules all be in the same repo is what I want.
This kind of obviates the need for .gitmodules entirely, if
git-checkout and friends will do the right thing.  I think I'll submit
some patches eventually once I have this figured out properly.

Have fun,

Avery

  reply	other threads:[~2008-04-09  3:34 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-31 20:59 Migrating svn to git with heavy use of externals D. Stuart Freeman
2008-04-08 18:07 ` D. Stuart Freeman
2008-04-08 20:06   ` Avery Pennarun
2008-04-08 20:49     ` D. Stuart Freeman
2008-04-08 21:01       ` Avery Pennarun
2008-04-08 22:47         ` D. Stuart Freeman
2008-04-09  3:03         ` Roman Shaposhnik
2008-04-09  3:33           ` Avery Pennarun [this message]
2008-04-09  4:39             ` Roman Shaposhnik
2008-04-09  6:34               ` Avery Pennarun
2008-04-09  6:43                 ` Junio C Hamano
2008-04-10  3:43                   ` Intricacies of submodules [was: Migrating svn to git with heavy use of externals] Roman Shaposhnik
2008-04-10  5:53                     ` Intricacies of submodules Junio C Hamano
2008-04-10 20:32                       ` Roman Shaposhnik
2008-04-11  5:20                         ` Junio C Hamano
2008-04-11 16:04                           ` Ping Yin
2008-04-11 22:32                             ` Junio C Hamano
2008-04-12  3:13                               ` Roman Shaposhnik
2008-04-12  5:11                                 ` Junio C Hamano
2008-04-14 19:52                                   ` Roman Shaposhnik
2008-04-15  1:13                                     ` Junio C Hamano
2008-04-15  2:13                                       ` Ping Yin
2008-04-16  3:49                                       ` Roman V. Shaposhnik
2008-04-17 18:09                                         ` Jeremy Maitin-Shepard
2008-04-17 19:06                                           ` Linus Torvalds
2008-04-17 20:04                                             ` Junio C Hamano
     [not found]                                               ` <32541b130804181128j57d76edcsbbd5fb8d4c782ae7@mail.gmail.com>
2008-04-18 18:30                                                 ` Avery Pennarun
2008-04-17 19:50                                           ` Roman V. Shaposhnik
2008-04-17 20:06                                             ` Martin Langhoff
2008-04-17 20:44                                               ` Junio C Hamano
2008-04-17 21:00                                                 ` Sverre Rabbelier
2008-04-17 21:25                                                   ` Martin Langhoff
2008-04-17 21:27                                                     ` Sverre Rabbelier
2008-04-17 21:31                                                       ` Martin Langhoff
2008-04-18  1:41                                                         ` Ping Yin
2008-04-17 22:29                                             ` Dmitry Potapov
2008-04-17 22:32                                             ` Linus Torvalds
2008-04-18  1:48                                               ` Ping Yin
2008-04-18 14:02                                             ` Jakub Narebski
2008-04-12  3:20                               ` Ping Yin
2008-04-14 19:56                           ` Roman Shaposhnik
2008-04-12  4:02                       ` Ping Yin
2008-04-12  5:25                         ` Junio C Hamano
2008-04-12  6:26                           ` Ping Yin
2008-04-10 16:07                     ` Intricacies of submodules [was: Migrating svn to git with heavy use of externals] Ping Yin
2008-04-10 19:27                       ` Roman Shaposhnik
2008-04-09 19:57                 ` Roman Shaposhnik
2008-04-09 20:27                   ` Avery Pennarun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32541b130804082033q55c795b5ieaa4e120956ff030@mail.gmail.com \
    --to=apenwarr@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=rvs@sun.com \
    --cc=stuart.freeman@et.gatech.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).