git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Avery Pennarun" <apenwarr@gmail.com>
To: "Git Mailing List" <git@vger.kernel.org>, aroben@apple.com
Subject: [BUG] Recent git-svn gets checksum errors on very large fetches
Date: Tue, 24 Jun 2008 23:23:57 -0400	[thread overview]
Message-ID: <32541b130806242023r167935f4off85cdd6a49d2750@mail.gmail.com> (raw)

My svn repo has 17000+ files in 1000+ directories.  I managed to
narrow my problem down to this sequence of steps:

    mkdir poo
    cd poo
    git init
    git svn init file:///home/averyp/svn.bak/branches/MyBranch
    git svn fetch -r3095 2>&1 | tee git.out

Which culminates in:

    Checksum mismatch: ThirdParty/whateverdir/blahblah
    expected: c342eaa17fe219a764c06642bb951474
        got: 848bbb56e4c22755ffb687fb70ae1ac6

For extra excitement, if I run the same command multiple times, the
exact file (blahblah) with the checksum mismatch differs each time.
However, it tends to be a file approximately the same "distance" down
in the fetch: it's almost always in whateverdir, which contains only
333 out of the 17000 files.

This leads me to believe there's a race condition or buffer problem
somewhere causing the problem.  Using git-bisect, I discovered that it
works fine in git 1.5.5.1, and that this patch is the one to blame:

  commit ffe256f9bac8a40ff751a9341a5869d98f72c285
  Author: Adam Roben <aroben@apple.com>
  Date:   Fri May 23 16:19:41 2008 +0200

    git-svn: Speed up fetch

Figures. :)

Reverting it directly seems to cause a conflict, so I can't test for
sure that the latest master with this patch reverted would work
correctly.

Not quite sure what could be at fault here, or what to do next.
Unfortunately it's hard to assemble a test case for timing-related
problems like this.  Thoughts?

Thanks,

Avery

                 reply	other threads:[~2008-06-25  3:24 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32541b130806242023r167935f4off85cdd6a49d2750@mail.gmail.com \
    --to=apenwarr@gmail.com \
    --cc=aroben@apple.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).