git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Avery Pennarun" <apenwarr@gmail.com>
To: "Junio C Hamano" <gitster@pobox.com>
Cc: "Johannes Schindelin" <Johannes.Schindelin@gmx.de>,
	"Dmitry Potapov" <dpotapov@gmail.com>,
	git@vger.kernel.org
Subject: Re: git rebase interactive: usability issue
Date: Wed, 25 Jun 2008 23:59:01 -0400	[thread overview]
Message-ID: <32541b130806252059l30431fcbld6196bedb32ab397@mail.gmail.com> (raw)
In-Reply-To: <7vbq1ovpl7.fsf@gitster.siamese.dyndns.org>

On 6/25/08, Junio C Hamano <gitster@pobox.com> wrote:
>  I was relunctant about the patch not because of "edit", but because I am
>  not convinced that it will _never_ make sense to be able to amend while
>  the sequence stops with a conflict (as the patch does not give us any way
>  to override this rather heavy-handed denial to continue).

Perhaps the problem is more that people are encouraged to --amend so
often that they end up doing it by accident.

What if 'edit' worked more like 'squash', in that it produced the new
tree, but didn't commit it yet?  Then you can reset things, commit
them, or rebase --continue (which commits automatically if needed)
just like wish 'squash'.

I think --continue used to not commit automatically, so I can see why
edit used to commit for you, but maybe that behaviour is not needed
anymore.

Right now the asymmetry of having to use --amend with 'edit' but not
with 'squash' is what leads me to make mistakes sometimes.

Have fun,

Avery

  reply	other threads:[~2008-06-26  4:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25 23:32 git rebase interactive: usability issue Dmitry Potapov
2008-06-26  2:17 ` Johannes Schindelin
2008-06-26  3:32   ` Junio C Hamano
2008-06-26  3:59     ` Avery Pennarun [this message]
2008-06-26 11:35     ` Dmitry Potapov
2008-06-26 12:13 ` Theodore Tso
2008-06-26 13:33   ` [PATCH v2] don't allow 'commit --amend' during rebase conflict resolution Dmitry Potapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=32541b130806252059l30431fcbld6196bedb32ab397@mail.gmail.com \
    --to=apenwarr@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=dpotapov@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).