From: "Avery Pennarun" <apenwarr@gmail.com>
To: "Brian Gernhardt" <benji@silverinsanity.com>
Cc: "Anders Melchiorsen" <mail@cup.kalibalik.dk>,
git@vger.kernel.org, gitster@pobox.com, peff@peff.net
Subject: Re: [PATCH v3] Advertise the ability to abort a commit
Date: Wed, 30 Jul 2008 17:09:13 -0400 [thread overview]
Message-ID: <32541b130807301409t2f1f3a80n44c62447c628f03a@mail.gmail.com> (raw)
In-Reply-To: <E2809CE9-1DEB-48DA-8E42-8BEAB376FED2@silverinsanity.com>
On 7/30/08, Brian Gernhardt <benji@silverinsanity.com> wrote:
> 'git commit' should return with an error any time it does not commit.
> Otherwise scripts could get confused, thinking everything went fine when
> nothing actually got done. Here, the user decided something was in error
> and canceled out, the same way using using ^C causes a non-zero return
> status.
The patch uses a non-zero exit code, which is an error status. But as
that's the case, I'm not sure why it's described in the changelog as
treating it "not as an error."
Have fun,
Avery
next prev parent reply other threads:[~2008-07-30 21:10 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-29 19:32 [PATCH] Advertise the ability to abort a commit Anders Melchiorsen
2008-07-29 20:12 ` [PATCH v2] " Anders Melchiorsen
2008-07-29 20:51 ` Junio C Hamano
2008-07-29 21:19 ` Anders Melchiorsen
2008-07-30 5:07 ` Jeff King
2008-07-30 5:11 ` Jeff King
2008-07-30 17:53 ` [PATCH v3] " Anders Melchiorsen
2008-07-30 19:01 ` Brian Gernhardt
2008-07-30 21:09 ` Avery Pennarun [this message]
2008-07-30 21:16 ` Brian Gernhardt
2008-07-30 21:53 ` Anders Melchiorsen
2008-07-31 5:50 ` Jeff King
2008-07-31 5:58 ` Junio C Hamano
2008-07-31 6:36 ` [PATCH] " Jeff King
2008-07-31 7:36 ` [PATCH v3] " Jeff King
2008-07-31 10:55 ` Petr Baudis
2008-07-31 11:09 ` Jeff King
2008-07-31 7:28 ` Anders Melchiorsen
2008-07-31 7:32 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32541b130807301409t2f1f3a80n44c62447c628f03a@mail.gmail.com \
--to=apenwarr@gmail.com \
--cc=benji@silverinsanity.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mail@cup.kalibalik.dk \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).