From: Avery Pennarun <apenwarr@gmail.com>
To: "Björn Steinbrink" <B.Steinbrink@gmx.de>
Cc: Scott Chacon <schacon@gmail.com>, git list <git@vger.kernel.org>
Subject: Re: EasyGit Integration
Date: Tue, 9 Jun 2009 16:42:33 -0400 [thread overview]
Message-ID: <32541b130906091342s7dd6064fud2205bee8af95aab@mail.gmail.com> (raw)
In-Reply-To: <20090609203747.GB13781@atjola.homenet>
2009/6/9 Björn Steinbrink <B.Steinbrink@gmx.de>:
> On 2009.06.09 15:52:46 -0400, Avery Pennarun wrote:
>> To be honest, I'm not convinced svn's use of the word "revert" is
>> really right, though. Git's isn't *really* right either, since it
>> actually makes a new commit, it doesn't remove the old one like it
>> sounds like it does. Maybe 'reverse' would be a better name for what
>> git does, and we should just introduce another word for what svn does.
>> (With CVS, you just deleted the file and then did a checkout/update
>> on it again, which made sense to me. That works in git too.)
>>
>> Crazy idea: we could actually make 'git revert' do both: given a
>> commit, it applies the reverse as it does now. Given filenames, it
>> simply brings them back to HEAD. But maybe that's too crazy.
>
> Doesn't seem that crazy to me. But maybe a bit problematic if you want
> to support both, "git checkout -- ." and "git checkout HEAD -- .". And
> adding DWIMmery there seems dangerous, as in:
>
> git revert == git checkout -- .
>
> git revert HEAD ==
> no uncommitted changes = revert commit HEAD
> uncommitted changes = revert to HEAD
Well, that's what I meant by "crazy" :)
Since so many of the other suggestions in eg are so simple and
non-conflicting, perhaps it's best to drop this branch of discussion
until the non-controversial bits are adopted. It would be bad to lose
other great improvements just because this one command is
problematic...
Have fun,
Avery
next prev parent reply other threads:[~2009-06-09 20:43 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-09 18:59 EasyGit Integration Scott Chacon
2009-06-09 19:43 ` Nicolas Pitre
2009-06-09 19:52 ` Avery Pennarun
2009-06-09 20:37 ` Björn Steinbrink
2009-06-09 20:42 ` Avery Pennarun [this message]
2009-06-10 12:13 ` Björn Steinbrink
2009-06-09 20:49 ` Elijah Newren
2009-06-10 1:09 ` Miles Bader
2009-06-09 20:12 ` Björn Steinbrink
2009-06-09 20:40 ` Elijah Newren
2009-06-09 21:18 ` Björn Steinbrink
2009-06-09 21:27 ` Björn Steinbrink
2009-06-09 21:36 ` Junio C Hamano
2009-06-09 21:48 ` Elijah Newren
2009-06-09 22:00 ` Elijah Newren
2009-06-10 12:52 ` Matthieu Moy
2009-06-09 22:14 ` Linus Torvalds
2009-06-09 22:30 ` Elijah Newren
2009-06-09 22:40 ` Linus Torvalds
2009-06-10 0:40 ` Mark Lodato
2009-06-10 3:11 ` Miles Bader
2009-06-10 3:32 ` Theodore Tso
2009-06-10 4:03 ` Linus Torvalds
2009-06-10 22:31 ` Felipe Contreras
2009-06-10 23:04 ` Linus Torvalds
2009-06-10 23:57 ` Scott Chacon
2009-06-11 0:15 ` Jakub Narebski
2009-06-11 0:30 ` Felipe Contreras
2009-06-11 0:42 ` Jakub Narebski
2009-06-12 20:57 ` Felipe Contreras
2009-06-12 21:21 ` Jakub Narebski
2009-06-12 21:48 ` Felipe Contreras
2009-06-12 22:05 ` Jakub Narebski
2009-06-12 22:30 ` Felipe Contreras
2009-06-13 1:24 ` Björn Steinbrink
2009-06-11 0:18 ` Felipe Contreras
2009-06-10 4:20 ` Elijah Newren
2009-06-10 14:40 ` Matthieu Moy
2009-06-10 1:25 ` Sam Vilain
2009-06-10 1:59 ` Linus Torvalds
2009-06-10 2:18 ` Junio C Hamano
2009-06-10 2:52 ` Sam Vilain
2009-06-10 6:43 ` Jakub Narebski
2009-06-10 3:27 ` Nicolas Pitre
2009-06-10 20:47 ` Junio C Hamano
2009-06-10 22:28 ` Elijah Newren
2009-06-10 16:48 ` Scott Chacon
2009-06-10 22:15 ` Felipe Contreras
2009-06-10 22:04 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32541b130906091342s7dd6064fud2205bee8af95aab@mail.gmail.com \
--to=apenwarr@gmail.com \
--cc=B.Steinbrink@gmx.de \
--cc=git@vger.kernel.org \
--cc=schacon@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).