From: Avery Pennarun <apenwarr@gmail.com>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Jeff King <peff@peff.net>, Nicolas Pitre <nico@cam.org>,
"Shawn O. Pearce" <spearce@spearce.org>,
Albert Astals Cid <aacid@kde.org>,
Junio C Hamano <gitster@pobox.com>,
Pau Garcia i Quiles <pgquiles@elpauer.org>,
git@vger.kernel.org
Subject: Re: [PATCH 3/3] transport: don't show push status if --quiet is given
Date: Wed, 5 Aug 2009 20:29:13 +0000 [thread overview]
Message-ID: <32541b130908051329w43882ca6ne0824b01da3948aa@mail.gmail.com> (raw)
In-Reply-To: <fabb9a1e0908051327l74e06afdvf3b35b5abde2e140@mail.gmail.com>
On Wed, Aug 5, 2009 at 8:27 PM, Sverre Rabbelier<srabbelier@gmail.com> wrote:
> On Wed, Aug 5, 2009 at 13:23, Jeff King<peff@peff.net> wrote:
>> + for (; ref; ref = ref->next) {
>> + switch (ref->status) {
>> + case REF_STATUS_NONE:
>> + case REF_STATUS_UPTODATE:
>> + case REF_STATUS_OK:
>> + break;
>> + default:
>> + return 1;
>> + }
>> + }
>
> Is my C getting sloppy or is this a non-looping loop? AFAICS it either
> return 1's on the first run, or breaks?
The "break" in this case breaks out of the switch, not the for.
Avery
next prev parent reply other threads:[~2009-08-05 20:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 21:27 Making git push output quieter Albert Astals Cid
2009-08-04 22:20 ` Pau Garcia i Quiles
2009-08-05 19:13 ` Albert Astals Cid
2009-08-05 19:26 ` Shawn O. Pearce
2009-08-05 19:51 ` Nicolas Pitre
2009-08-05 20:19 ` Jeff King
2009-08-05 20:22 ` [RFC/PATCH 1/3] push: add --quiet flag Jeff King
2009-08-05 20:22 ` [PATCH 2/3] transport: pass "quiet" flag to pack-objects Jeff King
2009-08-05 20:23 ` [PATCH 3/3] transport: don't show push status if --quiet is given Jeff King
2009-08-05 20:27 ` Sverre Rabbelier
2009-08-05 20:29 ` Avery Pennarun [this message]
2009-08-05 20:30 ` Sverre Rabbelier
2009-08-05 20:39 ` Junio C Hamano
2009-08-05 20:48 ` Jeff King
2009-08-05 21:01 ` Junio C Hamano
2009-08-05 21:17 ` Jeff King
2009-08-31 18:33 ` Sebastian Pipping
2009-08-31 19:28 ` Jeff King
2009-08-31 19:39 ` Sebastian Pipping
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32541b130908051329w43882ca6ne0824b01da3948aa@mail.gmail.com \
--to=apenwarr@gmail.com \
--cc=aacid@kde.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nico@cam.org \
--cc=peff@peff.net \
--cc=pgquiles@elpauer.org \
--cc=spearce@spearce.org \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).