From: Avery Pennarun <apenwarr@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Evan Farrer <evan.farrer@gmail.com>,
git@vger.kernel.org, Christian Couder <chriscool@tuxfamily.org>
Subject: Re: [PATCH/RFC] Add support for the google-chrome web browser
Date: Tue, 5 Jan 2010 12:20:40 -0500 [thread overview]
Message-ID: <32541b131001050920j2a569ec8u8811f1b0358f21ef@mail.gmail.com> (raw)
In-Reply-To: <7vr5q56rew.fsf@alter.siamese.dyndns.org>
On Tue, Jan 5, 2010 at 12:40 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Then we don't even have to add any specific support for "google-chrome" or
> anything that takes "$command $path..." and opens the documents.
>
> Is there a downside in this approach?
If someone has another firefox-derived browser installed with a
different name and tries to use it, this default wouldn't do the right
"firefoxy" thing, and would instead fail strangely. On the other
hand, right now it'll fail anyway, just not strangely.
So your proposed change would decrease the number of failures, but
increase the strangeness of the remaining failures. Maybe that's the
right thing to do though.
Avery
next prev parent reply other threads:[~2010-01-05 17:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-05 5:19 [PATCH/RFC] Add support for the google-chrome web browser Evan Farrer
2010-01-05 5:40 ` Junio C Hamano
2010-01-05 17:20 ` Avery Pennarun [this message]
2010-01-05 18:39 ` Junio C Hamano
2010-01-05 18:56 ` Avery Pennarun
2010-01-05 19:56 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32541b131001050920j2a569ec8u8811f1b0358f21ef@mail.gmail.com \
--to=apenwarr@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=evan.farrer@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).