From: Avery Pennarun <apenwarr@gmail.com>
To: Sverre Rabbelier <srabbelier@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
Nanako Shiraishi <nanako3@lavabit.com>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
git@vger.kernel.org
Subject: Re: [PATCH (v2) 2/2] rebase -i: teach --onto A...B syntax
Date: Fri, 8 Jan 2010 15:31:41 -0500 [thread overview]
Message-ID: <32541b131001081231x1b6ac8c1k30084e4abf8cc896@mail.gmail.com> (raw)
In-Reply-To: <fabb9a1e1001081222q7122872bu72cea4e393f272ac@mail.gmail.com>
On Fri, Jan 8, 2010 at 3:22 PM, Sverre Rabbelier <srabbelier@gmail.com> wrote:
> On Fri, Jan 8, 2010 at 15:16, Avery Pennarun <apenwarr@gmail.com> wrote:
>> This would resolve any other inconsistencies between the two as well,
>> notably that non-interactive rebase sometimes refuses to do the rebase
>> I requested because "Current branch master is up to date," while
>> interactive rebase is willing to do it. (Personally I prefer the
>> latter behaviour, since I don't like tools that think they're smarter
>> than me :))
>
> I taught rebase the -f|--force-rebase flag a little while back, you
> could use that :).
Thanks, I didn't know about that one. But my general point is still:
we seem to have two implementations when the functionality of one is
actually a superset of the other. As far as I can see, anyway. So
the obvious way to reduce the duplicated code is to simply eliminate
the less-featureful implementation.
Avery
next prev parent reply other threads:[~2010-01-08 20:32 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-04 8:39 What's cooking in git.git (Jan 2010, #01; Mon, 04) Junio C Hamano
2010-01-04 16:19 ` Matthieu Moy
2010-01-04 19:10 ` Junio C Hamano
2010-01-04 16:29 ` Johannes Sixt
2010-01-05 1:35 ` Junio C Hamano
2010-01-05 4:20 ` Jeff King
2010-01-05 5:18 ` Junio C Hamano
2010-01-05 20:49 ` Johannes Sixt
2010-01-06 7:47 ` Junio C Hamano
2010-01-06 9:08 ` Johannes Sixt
2010-01-06 17:04 ` Junio C Hamano
2010-01-05 5:57 ` Junio C Hamano
2010-01-05 6:40 ` Jeff King
2010-01-05 7:28 ` Tay Ray Chuan
2010-01-05 8:16 ` [PATCH] Teach --[no-]rerere-autoupdate option to merge, revert and friends Junio C Hamano
2010-01-05 11:31 ` What's cooking in git.git (Jan 2010, #01; Mon, 04) Johan Herland
2010-01-05 11:56 ` Ilari Liusvaara
2010-01-06 1:04 ` Junio C Hamano
2010-01-06 10:18 ` Nanako Shiraishi
2010-01-06 11:29 ` Johannes Schindelin
2010-01-06 17:07 ` Junio C Hamano
2010-01-07 11:05 ` [PATCH (v2) 1/2] rebase: fix --onto A...B parsing and add tests Nanako Shiraishi
2010-01-07 11:05 ` [PATCH (v2) 2/2] rebase -i: teach --onto A...B syntax Nanako Shiraishi
2010-01-07 20:19 ` Junio C Hamano
2010-01-07 21:10 ` Johannes Sixt
2010-01-08 20:16 ` Avery Pennarun
2010-01-08 20:22 ` Sverre Rabbelier
2010-01-08 20:31 ` Avery Pennarun [this message]
2010-01-08 20:37 ` Sverre Rabbelier
2010-01-08 23:21 ` A Large Angry SCM
2010-01-09 1:36 ` Johannes Schindelin
2010-01-09 21:02 ` Avery Pennarun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32541b131001081231x1b6ac8c1k30084e4abf8cc896@mail.gmail.com \
--to=apenwarr@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=nanako3@lavabit.com \
--cc=srabbelier@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).