From: Avery Pennarun <apenwarr@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Brad King <brad.king@kitware.com>,
git@vger.kernel.org, Lars Hjemli <hjemli@gmail.com>
Subject: Re: [PATCH 0/2] Support relative .git file in a submodule
Date: Fri, 8 Jan 2010 18:24:13 -0500 [thread overview]
Message-ID: <32541b131001081524g43d54a44i582dd286c1dfe7a5@mail.gmail.com> (raw)
In-Reply-To: <7vocl4urc6.fsf@alter.siamese.dyndns.org>
On Fri, Jan 8, 2010 at 6:09 PM, Junio C Hamano <gitster@pobox.com> wrote:
> Brad King <brad.king@kitware.com> writes:
>
>> ... if a submodule
>> has a .git file "symlink" with a relative path to the real submodule
>> repository then ...
>
> ... then I've always thought that is simply a misconfiguration (t0002
> seems to use full path for this exact reason). Is there a reason why
> relative path should be used/usable here, other than "being able to is
> better than not being able to"???
If I have a bunch of git repos in ~/src, and I decide I'd rather
rename it all to ~/source, it seems like it would be nice for all my
links not to be broken. This sort of thing can also happen if you
have NFS-mounted home directories on a farm of machines, and some of
them automount in /u/username and others use /home/username, for
example. I think this is the same reason that common sysadmin advice
is to use relative symlinks instead of absolute links.
This problem seems especially true with submodules. If the
submodule's repo is something like supermodule/.git/submodule.git, a
relative path would almost always be a appropriate, no?
Have fun,
Avery
next prev parent reply other threads:[~2010-01-08 23:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-08 22:36 [PATCH 0/2] Support relative .git file in a submodule Brad King
2010-01-08 22:36 ` [PATCH 1/2] Test update-index for a gitlink to a .git file Brad King
2010-01-08 22:36 ` [PATCH 2/2] Handle relative paths in submodule .git files Brad King
2010-01-08 23:09 ` [PATCH 0/2] Support relative .git file in a submodule Junio C Hamano
2010-01-08 23:24 ` Avery Pennarun [this message]
2010-01-09 3:36 ` [PATCH v2 " Brad King
2010-01-09 17:20 ` Junio C Hamano
2010-01-09 3:36 ` [PATCH v2 1/2] Test update-index for a gitlink to a .git file Brad King
2010-01-09 3:36 ` [PATCH v2 2/2] Handle relative paths in submodule .git files Brad King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32541b131001081524g43d54a44i582dd286c1dfe7a5@mail.gmail.com \
--to=apenwarr@gmail.com \
--cc=brad.king@kitware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hjemli@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).