From: Avery Pennarun <apenwarr@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Shawn O. Pearce" <spearce@spearce.org>,
"Mike.lifeguard" <mike.lifeguard@gmail.com>,
Scott Chacon <schacon@gmail.com>,
Jonathan Nieder <jrnieder@gmail.com>, git <git@vger.kernel.org>
Subject: Re: Tree with leading '0' modes in 1.7.0.3
Date: Fri, 26 Mar 2010 19:56:01 -0400 [thread overview]
Message-ID: <32541b131003261656h430d77a8q753c6141297e8f86@mail.gmail.com> (raw)
In-Reply-To: <7v7hoyabiv.fsf@alter.siamese.dyndns.org>
On Fri, Mar 26, 2010 at 7:50 PM, Junio C Hamano <gitster@pobox.com> wrote:
> "Shawn O. Pearce" <spearce@spearce.org> writes:
>
>> Scott, please fix that library on GitHub. JGit's fsck has a hard
>> failure on these malformed trees, because the leading '0' mode
>> causes the tree to come up with the wrong SHA-1 hash given its
>> logical content. They shouldn't be created like this.
>
> What is curious is that even though 6407180 (git-fsck-cache: be stricter
> about "tree" objects, 2005-07-27) does talk about zero-padding, it appears
> that we never had a version of git that padded mode in '0' in the entire
> history of write-tree (except that "notes tree" one, but even that didn't
> escape the laboratory).
It's apparently an easy mistake to make. bup did this for a while
until I added a 'git fsck' to its automated tests :)
The problem is that everything in git works perfectly with these
invalid file modes *except* fsck, and there's rarely a need to run
fsck, so this problem can hide for a long time.
Have fun,
Avery
next prev parent reply other threads:[~2010-03-26 23:56 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-26 21:56 Tree with leading '0' modes in 1.7.0.3 Shawn O. Pearce
2010-03-26 22:26 ` Jonathan Nieder
2010-03-26 22:29 ` Shawn O. Pearce
2010-03-26 22:40 ` Jonathan Nieder
2010-03-26 23:09 ` Junio C Hamano
2010-03-26 22:59 ` Mike.lifeguard
2010-03-26 23:05 ` Shawn O. Pearce
2010-03-26 23:22 ` Mike.lifeguard
2010-03-26 23:49 ` Jonathan Nieder
2010-03-26 23:50 ` Junio C Hamano
2010-03-26 23:56 ` Avery Pennarun [this message]
2010-03-27 0:00 ` Mike.lifeguard
2010-03-27 1:22 ` Shawn O. Pearce
2010-03-27 1:30 ` Nicolas Pitre
2010-03-27 1:34 ` Shawn O. Pearce
2010-03-27 1:56 ` Nicolas Pitre
2010-03-27 2:33 ` Avery Pennarun
2010-03-27 12:44 ` Scott Chacon
2010-03-27 14:21 ` Nicolas Pitre
2010-03-27 19:14 ` Shawn O. Pearce
2010-03-27 19:30 ` A Large Angry SCM
2010-03-27 19:32 ` Shawn O. Pearce
2010-03-27 19:39 ` A Large Angry SCM
2010-03-27 19:44 ` A Large Angry SCM
2010-03-27 19:57 ` A Large Angry SCM
2010-03-28 17:38 ` Sitaram Chamarty
2010-03-28 23:28 ` A Large Angry SCM
2010-03-27 20:13 ` A Large Angry SCM
2010-03-27 20:16 ` Junio C Hamano
2010-03-27 22:16 ` Avery Pennarun
2010-03-27 5:16 ` Junio C Hamano
2010-03-27 19:20 ` Shawn O. Pearce
2010-03-27 20:04 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32541b131003261656h430d77a8q753c6141297e8f86@mail.gmail.com \
--to=apenwarr@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jrnieder@gmail.com \
--cc=mike.lifeguard@gmail.com \
--cc=schacon@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).