From: Dan Savilonis <djs@n-cube.org>
To: Alex Riesen <raa.lkml@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git format-patch from date never set
Date: Sat, 25 Jul 2009 18:49:34 -0400 [thread overview]
Message-ID: <325c62f60907251549o27ebc8f2gcd1d728adb662ffd@mail.gmail.com> (raw)
In-Reply-To: <81b0412b0907251531u7566813fr10bdd70187e9aca6@mail.gmail.com>
On Sat, Jul 25, 2009 at 6:31 PM, Alex Riesen<raa.lkml@gmail.com> wrote:
> Neither. This is not a date, but a part of "loosely defined" mbox format.
>
In the examples of mbox format I have found, the date in the From:
line is generally the same as in the Date: line, albeit in a more
ambiguous format. Further, the the git code treats it as a date and
attempts to set it. It remains at the default date only because
git_committer_info() is called without GIT_COMMITTER_DATE set.
So is the code misleading? Was it designed to just meet the minimal
requirement of having a date-like string to comform to the mbox
format? What's the disadvantage to using the real commit date?
--
Dan
next prev parent reply other threads:[~2009-07-25 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-25 21:39 git format-patch from date never set Dan Savilonis
2009-07-25 22:31 ` Alex Riesen
2009-07-25 22:49 ` Dan Savilonis [this message]
2009-07-25 23:03 ` Junio C Hamano
2009-07-26 0:06 ` Dan Savilonis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=325c62f60907251549o27ebc8f2gcd1d728adb662ffd@mail.gmail.com \
--to=djs@n-cube.org \
--cc=git@vger.kernel.org \
--cc=raa.lkml@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).