From: "Rubén Justo" <rjusto@gmail.com>
To: Isoken June Ibizugbe via GitGitGadget <gitgitgadget@gmail.com>,
git@vger.kernel.org
Cc: Isoken June Ibizugbe <isokenjune@gmail.com>
Subject: Re: [PATCH 2/2] branch.c: adjust error messages to coding guidelines
Date: Fri, 13 Oct 2023 20:25:08 +0200 [thread overview]
Message-ID: <329f635f-2050-421e-bd0d-943f8ad0de22@gmail.com> (raw)
In-Reply-To: <91e4ad3984147fcc277254a3f6836bf79f5c9550.1697211227.git.gitgitgadget@gmail.com>
On 13-oct-2023 15:33:47, Isoken June Ibizugbe via GitGitGadget wrote:
> replace_each_worktree_head_symref(worktrees, oldref.buf, newref.buf,
> logmsg.buf))
> - die(_("branch renamed to %s, but HEAD is not updated!"), newname);
> + die(_("branch renamed to %s, but HEAD is not updated"), newname);
Thanks. This change is not explicitly suggested in the guidelines, but I think
it fits well in the spirit of this series.
> @@ -965,7 +965,7 @@ int cmd_branch(int argc, const char **argv, const char *prefix)
> const char *start_name = argc == 2 ? argv[1] : head;
>
> if (filter.kind != FILTER_REFS_BRANCHES)
> - die(_("the -a, and -r, options to 'git branch' do not take a branch name\n"
> + die(_("the -a, and -r, options to 'git branch' do not take a branch name.\n"
You have mistakenly deleted this full stop in the previous [1/2] patch.
Therefore, if you stop doing so, you do not need to add it here.
next prev parent reply other threads:[~2023-10-13 18:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-13 15:33 [PATCH 0/2] [Outreachy][PATCH v2] branch.c: adjust error messages to coding guidelines Isoken June Ibizugbe via GitGitGadget
2023-10-13 15:33 ` [PATCH 1/2] branch.c: ammend error messages for die() Isoken June Ibizugbe via GitGitGadget
2023-10-13 15:33 ` [PATCH 2/2] branch.c: adjust error messages to coding guidelines Isoken June Ibizugbe via GitGitGadget
2023-10-13 15:40 ` Isoken Ibizugbe
2023-10-13 18:29 ` Junio C Hamano
2023-10-13 18:25 ` Rubén Justo [this message]
2023-10-13 18:30 ` [PATCH 0/2] [Outreachy][PATCH v2] " Rubén Justo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=329f635f-2050-421e-bd0d-943f8ad0de22@gmail.com \
--to=rjusto@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=isokenjune@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).