From: Tim Henigan <tim.henigan@gmail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH] Use time_t for timestamps returned by approxidate() instead of unsigned
Date: Sat, 24 Jan 2009 12:14:47 -0500 [thread overview]
Message-ID: <32c343770901240914n3fc76fe0vbe844e50cbc0bbf@mail.gmail.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0901241757140.13232@racer>
On Sat, Jan 24, 2009 at 11:58 AM, Johannes Schindelin
<Johannes.Schindelin@gmx.de> wrote:
>> Should I update the GitWiki page to remove this Janitor task or do you
>> keep it as a test to see if people are properly searching the mail
>> archives?
>
> Yes, please!
I did some more digging and found this last comment on the subject by Linus:
https://kerneltrap.org/mailarchive/git/2008/11/6/4014344
Given this, should the janitor task simply be deleted (since using
unsigned longs are safe until year 2038 is considered) or should it be
updated to change all timestamps to 64-bit values?
Also, there are still ~37 references to time_t in the code (e.g. the
index_state struct in cache.h). Should these be phased out in favor
of unsigned longs (or perhaps 64-bit types)?
Perhaps the Janitor task should be changed to do this so that all the
code handles timestamps consistently? (btw, I will volunteer to do
this if desired).
Thanks,
Tim
next prev parent reply other threads:[~2009-01-24 17:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-22 23:07 [PATCH] Use time_t for timestamps returned by approxidate() instead of unsigned Tim Henigan
2009-01-24 5:22 ` Markus Heidelberg
2009-01-24 6:27 ` Johannes Schindelin
2009-01-24 16:13 ` Tim Henigan
2009-01-24 16:37 ` Wincent Colaiuta
2009-01-24 16:58 ` Johannes Schindelin
2009-01-24 17:14 ` Tim Henigan [this message]
2009-01-24 17:32 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32c343770901240914n3fc76fe0vbe844e50cbc0bbf@mail.gmail.com \
--to=tim.henigan@gmail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox