From: Tim Henigan <tim.henigan@gmail.com>
To: Stephen Boyd <bebarino@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Johan Herland <johan@herland.net>,
Thomas Rast <trast@student.ethz.ch>
Subject: Re: [RFC/PATCH] notes: rework subcommands and parse options
Date: Thu, 25 Feb 2010 13:26:19 -0500 [thread overview]
Message-ID: <32c343771002251026n6d55ea7csbdb4c8899bb5fded@mail.gmail.com> (raw)
In-Reply-To: <1267086261-7675-1-git-send-email-bebarino@gmail.com>
On Thu, Feb 25, 2010 at 3:24 AM, Stephen Boyd <bebarino@gmail.com> wrote:
>
> + else {
> + result = error("Unknown subcommand: %s", argv[0]);
> + }
In the case where an unknown subcommand was given, shouldn't the usage
instructions be printed? i.e. add the following after the error()?
usage_with_options(git_notes_usage, options);
-Tim
next prev parent reply other threads:[~2010-02-25 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-25 8:24 [RFC/PATCH] notes: rework subcommands and parse options Stephen Boyd
2010-02-25 18:26 ` Tim Henigan [this message]
2010-02-26 11:22 ` Johan Herland
2010-02-27 8:59 ` [PATCH] " Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32c343771002251026n6d55ea7csbdb4c8899bb5fded@mail.gmail.com \
--to=tim.henigan@gmail.com \
--cc=bebarino@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=johan@herland.net \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).