From: stephen_leake@stephe-leake.org
To: <git@vger.kernel.org>
Subject: Re: aborted 'git fetch' leaves workspace unusable
Date: Tue, 31 Dec 2013 01:19:25 -0700 [thread overview]
Message-ID: <32eeea08963ec4438f97ff9ef6553a75@stephe-leake.org> (raw)
Junio C Hamano <gitster@pobox.com> writes:
> stephen_leake@stephe-leake.org writes:
>
>> That left the workspace unusable:
>>
>> - .git/FETCH_HEAD is empty
>>
>> that causes 'git rev-parse FETCH_HEAD' to fail with a confusing
>> error message.
>
> This is not limited to your Cygwin environment. I can see that we
> leave an empty file there after a failed fetch with
>
> $ git fetch ssh://no.such.place/
>
> But I would not call it leaving "the workspace unusable". If you
> ask "git rev-parse" "What is in FETCH_HEAD?", you would get "that is
> not even a revision", which is what you would get.
Yes, and I also discovered that FETCH_HEAD is not present after a
clone.
So in general I need to be tolerant of an empty/missing FETCH_HEAD (I'm
actually working on an Emacs front end for git).
However, in this case, even running the fetch was a mistake; I would
have prefered that it leave FETCH_HEAD in its previous state. Is there
any way to reconstruct it? refs/heads/master was untouched, but I don't
know how to find the fetched head.
>> - 'git fetch' just hangs after outputting:
>>
>> remote: Counting objects: 15, done.
>> remote: Compressing objects: 100% (8/8), done.
>> remote: Total 9 (delta 5), reused 0 (delta 0)
>
> This looks more serious, but I suspect it is totally unrelated to
> your previous fetch failing and leaving FETCH_HEAD there. Is this
> "'git fetch' hangs" reproduce in a clean clone _without_ first
> encountering the failure (due to the forgotton "ssh-add")?
no, the clone worked (so the network is up, the server is up), and a
subsequent 'git fetch' did not hang. Although there was also nothing to
fetch.
I'll have to wait until there is something to fetch, and see if I can
reproduce the bug. Or set up a git server and test branch - not high
enough on my priority list.
--
-- Stephe
next reply other threads:[~2013-12-31 8:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-31 8:19 stephen_leake [this message]
2014-01-02 18:09 ` aborted 'git fetch' leaves workspace unusable Junio C Hamano
2014-01-03 3:28 ` Stephen Leake
2014-01-03 17:58 ` Junio C Hamano
-- strict thread matches above, loose matches on Subject: below --
2013-12-30 17:07 stephen_leake
2013-12-30 19:37 ` Junio C Hamano
2013-12-30 19:54 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=32eeea08963ec4438f97ff9ef6553a75@stephe-leake.org \
--to=stephen_leake@stephe-leake.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).