From: Phillip Wood <phillip.wood123@gmail.com>
To: Collin Funk <collin.funk1@gmail.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>
Cc: Matthieu Beauchamp <matthieu.beauchamp.boulay@gmail.com>,
Matthieu Beauchamp-Boulay via GitGitGadget
<gitgitgadget@gmail.com>,
git@vger.kernel.org, Matheus Tavares <matheus.tavb@gmail.com>,
Johannes Schindelin <johannes.schindelin@gmx.de>
Subject: Re: [PATCH] ignores: handle non UTF-8 exclude files
Date: Wed, 7 Jan 2026 14:28:08 +0000 [thread overview]
Message-ID: <331595ad-5c6a-4e01-bd0f-1dabb4bc0fcb@gmail.com> (raw)
In-Reply-To: <87secimchc.fsf@gmail.com>
On 07/01/2026 01:35, Collin Funk wrote:
>
> An unfortunate trend that I have seen with Rust programs is that they
> completely disregard the systems locale. E.g. using
> LC_ALL=en_US.ISO-8859-1 and passing an "À" character as an option will
> typically fail since it is encoded as 0xC0 which is not a valid UTF-8
> character.
>
> I figured it was worth bringing up since Git may wany to think about it
> some before introducing more Rust. I think it can be worked around by
> using OsString [1], but I guess many people choose not to.
Git will certainly want to continue to support non-utf8 encodings.
That's perfectly possible in rust but in my (rather limited) experience
it does take a bit more effort than the equivalent code using the
standard library's String type. I find it particularly annoying that
"cargo run" refuses to pass non-utf8 arguments to the program being run
when the program has been carefully written to support them.
Thanks
Phillip
next prev parent reply other threads:[~2026-01-07 14:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-03 22:16 [PATCH] ignores: handle non UTF-8 exclude files Matthieu Beauchamp-Boulay via GitGitGadget
2026-01-04 2:54 ` Junio C Hamano
2026-01-06 19:52 ` Matthieu Beauchamp
2026-01-04 17:35 ` Torsten Bögershausen
2026-01-06 20:32 ` Matthieu Beauchamp
2026-01-07 14:36 ` Phillip Wood
2026-01-04 19:40 ` brian m. carlson
2026-01-06 20:45 ` Matthieu Beauchamp
2026-01-06 23:22 ` brian m. carlson
2026-01-07 1:35 ` Collin Funk
2026-01-07 14:28 ` Phillip Wood [this message]
2026-01-07 23:38 ` brian m. carlson
2026-01-08 1:13 ` Collin Funk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=331595ad-5c6a-4e01-bd0f-1dabb4bc0fcb@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=collin.funk1@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=johannes.schindelin@gmx.de \
--cc=matheus.tavb@gmail.com \
--cc=matthieu.beauchamp.boulay@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).