From: "René Scharfe" <l.s.r@web.de>
To: Ghanshyam Thakkar <shyamthakkar001@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: [PATCH] t-example-decorate: remove test messages
Date: Wed, 31 Jul 2024 11:21:18 +0200 [thread overview]
Message-ID: <333d0d04-5fe6-4fca-8cce-1bb557740a70@web.de> (raw)
In-Reply-To: <D33CBWZJZSRS.1V3U16NM91BOA@gmail.com>
Am 31.07.24 um 03:41 schrieb Ghanshyam Thakkar:
>
> If we want to further simplify, I don't see any need for having 'ret'
> either and to just call the methods in check():
>
> check(add_decoration(&vars->n, vars->two, NULL), ==, NULL);
>
> which would also provide more context in the stdout rather than printing
> 'check(ret == NULL)'. But, I believe you would have already considered
> that but kept 'ret' in favor of code readability, so I am also fine with
> it. Thanks for patch.
Good idea! Worth a separate patch, though.
René
prev parent reply other threads:[~2024-07-31 9:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-30 14:00 [PATCH] t-example-decorate: remove test messages René Scharfe
2024-07-31 1:41 ` Ghanshyam Thakkar
2024-07-31 9:21 ` René Scharfe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=333d0d04-5fe6-4fca-8cce-1bb557740a70@web.de \
--to=l.s.r@web.de \
--cc=git@vger.kernel.org \
--cc=shyamthakkar001@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox