From: "Windl, Ulrich" <u.windl@ukr.de>
To: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: git context diff does not recognize shell function name
Date: Thu, 12 Nov 2026 13:39:58 +0000 [thread overview]
Message-ID: <340dc2eef42f4f6690c58765a07621e1@ukr.de> (raw)
[-- Attachment #1: Type: text/plain, Size: 858 bytes --]
Hi!
In git 2.51.0 I found a minor issue:
"git diff" did not show the corresponding shell function name. Admittedly I used a somewhat uncommon line-breaking:
The context in question looks like this:
---
...
run_query()
{
local p_l_0="$1" LOG_BASE="$2" SUFFIX="$3" URL_BASE="$4" URL="$5" \
_COUNT="${6:-$COUNT}" RESPONSE_CHECKER="$7"
local me="${FUNCNAME[0]}" m
...
---
The context diff looked like this:
---
...
@@ -193,6 +188,36 @@ get_params()
...
run_query()
{
@@ -201,10 +226,9 @@ _COUNT="${6:-$COUNT}" RESPONSE_CHECKER="$7"
local me="${FUNCNAME[0]}" m
...
---
("..." is deleted lines)
So this may be a combination of unfortunate context sequencing and the first line of the new context being unusual.
The second chunk would still be the same context, namely "run_query()".
Kind regards,
Ulrich Windl
[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 5581 bytes --]
reply other threads:[~2026-11-12 13:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=340dc2eef42f4f6690c58765a07621e1@ukr.de \
--to=u.windl@ukr.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox