git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: What's cooking in git.git (Sep 2024, #08; Fri, 20)
Date: Sun, 22 Sep 2024 21:31:58 -0400	[thread overview]
Message-ID: <34346998-deac-4e1f-9d5f-218f664e9e08@gmail.com> (raw)
In-Reply-To: <xmqqed5ddexk.fsf@gitster.g>

On 9/20/24 8:32 PM, Junio C Hamano wrote:

 > * ds/pack-name-hash-tweak (2024-09-19) 6 commits
 >   - test-tool: add helper for name-hash values
 >   - p5313: add size comparison test
 >   - git-repack: update usage to match docs
 >   - pack-objects: add GIT_TEST_FULL_NAME_HASH
 >   - repack: test --full-name-hash option
 >   - pack-objects: add --full-name-hash option
 >
 >   In a repository with too many (more than --window size) similarly
 >   named files, "git repack" would not find good delta-base candidate
 >   and worse, it may not use a blob from exactly the same path as a
 >   good delta-base candidate.  Optionally replace the name hash so
 >   that only blobs at the same path and nothing else are used as
 >   delta-base candidate.
 >
 >   Will merge to 'next'?
 >   source: <pull.1785.v2.git.1726692381.gitgitgadget@gmail.com>

There was some speculation [1] that maybe this --full-name-hash option
would be considered redundant or irrelevant when the --path-walk feature
is submitted/reviewed/merged. I'm not sure that that is the case, but
maybe we should leave this open a bit longer for folks to weigh in on
it?

[1] 
https://lore.kernel.org/git/81bc5d69-cf50-409d-ac64-5b9b3f722ace@app.fastmail.com/T/#me45c4fd489bae987785cddb9580339095095fa9e

Thanks,
-Stolee


  parent reply	other threads:[~2024-09-23  1:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-21  0:32 What's cooking in git.git (Sep 2024, #08; Fri, 20) Junio C Hamano
2024-09-21  1:40 ` Junio C Hamano
2024-09-21 14:50 ` shejialuo
2024-09-23  1:31 ` Derrick Stolee [this message]
2024-09-23 17:20   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34346998-deac-4e1f-9d5f-218f664e9e08@gmail.com \
    --to=stolee@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).