From: "Paolo Teti" <paolo.teti@gmail.com>
To: git@vger.kernel.org
Subject: BUG in fixup_pack_header_footer(...) / pack-write.c checksum error never raised
Date: Tue, 15 May 2007 13:47:18 +0200 [thread overview]
Message-ID: <34a7ae040705150447k2e770b5ag3629632f61b813a0@mail.gmail.com> (raw)
In fixup_pack_header_footer(...) file pack-write.c
We have to change the size_t value returned by
xread() in ssize_t, otherwise the next check on negative
values has no sense.
size_t is an unsigned type!
I can't write now a patch because I'm on a customer site
and I can't install GIT...
I'm just looking at the souce code using gitweb during a coffebreak.
Someone can fix it?..
Pao
next reply other threads:[~2007-05-15 11:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-15 11:47 Paolo Teti [this message]
2007-05-15 12:39 ` [PATCH] Fix signedness on return value from xread() Johan Herland
2007-05-15 12:48 ` Paolo Teti
2007-05-15 12:49 ` [PATCH] Ensure return value from xread() is always stored into an ssize_t Johan Herland
2007-05-15 16:12 ` Dana How
2007-05-15 16:21 ` Johan Herland
2007-05-15 23:24 ` [PATCH] Fix signedness on return value from xread() Shawn O. Pearce
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34a7ae040705150447k2e770b5ag3629632f61b813a0@mail.gmail.com \
--to=paolo.teti@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).