git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Paolo Teti" <paolo.teti@gmail.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>
Cc: git@vger.kernel.org
Subject: Re: git-rebase (1.5.0.6) errors
Date: Fri, 18 May 2007 12:31:51 +0200	[thread overview]
Message-ID: <34a7ae040705180331x1a86782fh3b2c6a87db32030e@mail.gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0705181130570.28356@kivilampi-30.cs.helsinki.fi>

2007/5/18, Ilpo Järvinen <ilpo.jarvinen@helsinki.fi>:
> Hi,
>
>
> ijjarvin@kivilampi-30:~/work/src/submit$ git-rebase net-2.6.22-origin
> First, rewinding head to replay your work on top of it...
> HEAD is now at d739437... [IPV4]: Correct rp_filter help text.
> fatal: cannot convert from utf-8 to utf-8


Now I can't test or try to reproduce your error,
but looking at the source code (only with gitweb)
I have found another bad use of size_t instead of ssize_t
in the reencode_string(..) that take part at the conversion process.

Using size_t in the next portion of code the check "count == -1" is never true.

while (1) {
		size_t cnt = iconv(conv, &cp, &insz, &outpos, &outsz);

		if (cnt == -1) {
			size_t sofar;
			if (errno != E2BIG) {
				free(out);
				iconv_close(conv);
				return NULL;
			}


Please someone could fixes this bad use of size_t?..

Sorry, but now I can't install/use git because I'm on a customer workstation..

  reply	other threads:[~2007-05-18 10:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-18  8:47 git-rebase (1.5.0.6) errors Ilpo Järvinen
2007-05-18 10:31 ` Paolo Teti [this message]
2007-05-18 10:49   ` David Kastrup
2007-05-18 11:29     ` Paolo Teti
2007-05-18 14:02   ` Ilpo Järvinen
2007-05-18 14:39     ` Paolo Teti
     [not found]       ` <864pmamb6b.fsf@lola.quinscape.zz>
2007-05-18 15:08         ` Paolo Teti
2007-05-20 12:43     ` Jan Hudec
2007-05-20 19:02       ` Ilpo Järvinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=34a7ae040705180331x1a86782fh3b2c6a87db32030e@mail.gmail.com \
    --to=paolo.teti@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=ilpo.jarvinen@helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).