From: Dominik Fischer <d.f.fischer@web.de>
To: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH/RFC/GSoC 0/2] add a add.patch config variable
Date: Thu, 21 Apr 2016 18:30:04 +0200 [thread overview]
Message-ID: <34fb607f-1c4c-528a-cb5d-eca95e0e7c68@web.de> (raw)
In-Reply-To: <alpine.DEB.2.20.1604211737170.2826@virtualbox>
Indeed this needs more explanations for everyone who did not read the
posts before.
I strove to create an add.patch configuration option that did the same
as always passing the parameter --patch to git-add. Junio C Hamano then
made me aware that when set, this option would influence and possibly
destroy other commands that internally use git-add. So I implemented the
recursion counter, which is now the first of the two commits. With this,
git-add is able to only consider the configuration option when run
directly by the user, not affecting any commands building upon it.
I would be interested whether this is a suited method to restrict the
effect of a configuration option to cases where a command is explicitly
invoked by the user.
Regards.
next prev parent reply other threads:[~2016-04-21 16:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-24 21:09 [GSoC] Proposal XZS
2016-03-24 21:09 ` [PATCH/GSoC] add a add.patch config variable XZS
2016-03-24 21:20 ` Junio C Hamano
2016-03-25 0:43 ` Dominik Fischer
2016-03-25 6:30 ` Junio C Hamano
2016-03-25 7:01 ` Christian Couder
2016-04-21 9:15 ` [PATCH/RFC/GSoC 0/2] " XZS
2016-04-21 9:15 ` [PATCH/RFC/GSoC 1/2] count recursion depth XZS
2016-04-21 15:39 ` [PATCH/RFC/GSoC 0/2] add a add.patch config variable Johannes Schindelin
2016-04-21 16:30 ` Dominik Fischer [this message]
2016-04-21 16:43 ` Matthieu Moy
2016-04-21 16:47 ` Junio C Hamano
2016-04-21 17:28 ` Dominik Fischer
2016-04-22 6:45 ` Johannes Schindelin
2016-04-22 6:42 ` Johannes Schindelin
2016-04-21 9:15 ` [PATCH/RFC/GSoC 2/2] " XZS
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=34fb607f-1c4c-528a-cb5d-eca95e0e7c68@web.de \
--to=d.f.fischer@web.de \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).