From: "Bert Wesarg" <bert.wesarg@googlemail.com>
To: "Petr Baudis" <pasky@suse.cz>
Cc: "Bert Wesarg" <bert.wesarg@googlemail.com>, git@vger.kernel.org
Subject: Re: [TopGit PATCH] tg.sh: Check for read permissions of help files
Date: Sat, 9 Aug 2008 09:35:19 +0200 [thread overview]
Message-ID: <36ca99e90808090035r6331a118k5a26486de1acf002@mail.gmail.com> (raw)
In-Reply-To: <1218009771-30358-1-git-send-email-bert.wesarg@googlemail.com>
Petr,
On Wed, Aug 6, 2008 at 10:02, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
> - elif [ -f "@sharedir@/tg-$1.txt" ] ; then
> + elif [ -f "@sharedir@/tg-$1.txt" -a -r "@sharedir@/tg-$1.txt" ] ; then
I saw your simplified commit for this, but you should know, that '-r'
tests only for read permissions, not for a regular file, so this test
succeed also for a pipe/socket for which do you have read permissions.
Bert
> cat "@sharedir@/tg-$1.txt"
> else
> echo "`basename $0`: no help for $1" 1>&2
> --
> tg: (e311d15..) t/check-read-permissions-of-help-files (depends on: master)
>
next prev parent reply other threads:[~2008-08-09 7:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-08 6:43 [TopGit PATCH] tg.sh: it's info/attributes not info/gitattributes Bert Wesarg
2008-08-07 16:39 ` [TopGit PATCH] Makefile: mkdir $(bindir) Bert Wesarg
2008-08-06 8:02 ` [TopGit PATCH] tg.sh: Check for read permissions of help files Bert Wesarg
2008-08-06 7:49 ` [TopGit PATCH] tg.sh: Runtime tg-* command check Bert Wesarg
2008-08-06 2:43 ` [PATCH] [TopGit] Pretty print the help creation commands in Makefile Russell Steicke
2008-08-09 0:28 ` Petr Baudis
2008-08-09 7:35 ` Bert Wesarg [this message]
2008-08-09 8:24 ` [TopGit PATCH] tg.sh: Check for read permissions of help files Petr Baudis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36ca99e90808090035r6331a118k5a26486de1acf002@mail.gmail.com \
--to=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).