From: "Bert Wesarg" <bert.wesarg@googlemail.com>
To: "martin f. krafft" <madduck@debian.org>,
"Junio C Hamano" <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [TopGit PATCH] Check for help invocation before setup
Date: Fri, 21 Nov 2008 10:19:01 +0100 [thread overview]
Message-ID: <36ca99e90811210119s215513a8m7c12c8d55fd54d70@mail.gmail.com> (raw)
In-Reply-To: <1227110623-4474-2-git-send-email-madduck@debian.org>
Hi,
On Wed, Nov 19, 2008 at 17:03, martin f. krafft <madduck@debian.org> wrote:
> The user ought to be able to call `tg help` from anywhere in the
> filesystem, not just Git repositories, so the help parsing has to happen
> before the calls to git git binary.
>
> Debian bug: #501982
I really second this. Plus, I think its crucial to check that we are
not inside the .git directory before setting up topgit. Because git
rev-parse --git-dir only works in the top .git dir, not deeper (i.e.
inside .git/refs) and will always return ".".
$(git rev-parse --is-inside-work-tree) ||
die "Not in a git working directory"
Bert
next prev parent reply other threads:[~2008-11-21 9:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-19 16:03 [TopGit] Improve help output martin f. krafft
2008-11-19 16:03 ` [TopGit PATCH] Check for help invocation before setup martin f. krafft
2008-11-19 16:03 ` [TopGit PATCH] Change tg help exit code to 0 martin f. krafft
2008-11-19 16:03 ` [TopGit PATCH] Check for cmddir earlier martin f. krafft
2008-11-19 16:03 ` [TopGit PATCH] Print help output when no command is given martin f. krafft
2008-11-19 18:24 ` [TopGit PATCH] Check for help invocation before setup Petr Baudis
2008-11-19 18:32 ` martin f krafft
2008-11-19 18:39 ` Petr Baudis
2008-11-20 11:48 ` martin f krafft
2008-11-21 9:19 ` Bert Wesarg [this message]
2008-11-21 12:06 ` TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup) martin f krafft
2008-11-21 12:09 ` [TopGit PATCH] Ensure we are inside a Git worktree martin f. krafft
2008-11-21 12:15 ` TopGit: ensure worktree (was: [TopGit PATCH] Check for help invocation before setup) Bert Wesarg
2008-11-21 12:18 ` Bert Wesarg
2008-11-21 12:31 ` martin f krafft
2008-11-21 12:23 ` martin f krafft
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36ca99e90811210119s215513a8m7c12c8d55fd54d70@mail.gmail.com \
--to=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=madduck@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).