From: Bert Wesarg <bert.wesarg@googlemail.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: Petr Baudis <pasky@suse.cz>,
git@vger.kernel.org, martin f krafft <madduck@debian.org>
Subject: Re: [TopGit PATCH] hooks/pre-commit.sh: fix it again
Date: Wed, 25 Mar 2009 13:24:08 +0100 [thread overview]
Message-ID: <36ca99e90903250524g3549b629g8ce1947f741878f7@mail.gmail.com> (raw)
In-Reply-To: <20090325122027.GB30873@pengutronix.de>
2009/3/25 Uwe Kleine-König <u.kleine-koenig@pengutronix.de>:
> On Wed, Mar 25, 2009 at 12:43:04PM +0100, Bert Wesarg wrote:
>> First I think the '#' is a leftover, second this is now a bashism.
> according to bash(1):
>
> If pattern begins with #, it must match at the beginning of the
> expanded value of parameter.
That is obviously true, I first removed this # and than switch to bash
(after it stills failed), so this was just thinking not testing.
>
> And I noticed, too, that this is a bashism. Using dash it fails, even
> with your patch.
>
> I would prefer to really fix it now.
Thanks. I intended this patch as a bug report.
Bert
>
> Best regards
> Uwe
>
> --
> Pengutronix e.K. | Uwe Kleine-König |
> Industrial Linux Solutions | http://www.pengutronix.de/ |
>
next prev parent reply other threads:[~2009-03-25 12:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-25 11:43 [TopGit PATCH] hooks/pre-commit.sh: fix it again Bert Wesarg
2009-03-25 12:17 ` martin f krafft
2009-03-25 12:20 ` Uwe Kleine-König
2009-03-25 12:24 ` Bert Wesarg [this message]
2009-03-25 21:44 ` Uwe Kleine-König
2009-03-26 9:00 ` [PATCH TopGit] hooks/pre-commit.sh: fix bashism Uwe Kleine-König
2009-03-26 9:29 ` Marc Kleine-Budde
2009-03-26 14:21 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36ca99e90903250524g3549b629g8ce1947f741878f7@mail.gmail.com \
--to=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=madduck@debian.org \
--cc=pasky@suse.cz \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).