From: Bert Wesarg <bert.wesarg@googlemail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH v3] Give the hunk comment its own color
Date: Fri, 27 Nov 2009 09:44:01 +0100 [thread overview]
Message-ID: <36ca99e90911270044o68375902l3a0d2a4afa726a91@mail.gmail.com> (raw)
In-Reply-To: <7v3a40tl9t.fsf@alter.siamese.dyndns.org>
On Fri, Nov 27, 2009 at 09:38, Junio C Hamano <gitster@pobox.com> wrote:
> I was slightly surprised that this seems to have differences other than
> the flipping of the default color since the last one, especially after you
> sounded like you would be sending with only that change.
v3 does only that and adopt the change to the t/t4034-diff-words.sh
test. There I set an explicit value of func to magenta for testing.
Maybe you missed v2 (Message-Id:
<1258557087-31540-1-git-send-email-bert.wesarg@googlemail.com>)? Which
fixed the test and also a small bug.
Bert
>
next prev parent reply other threads:[~2009-11-27 8:44 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-18 11:30 [PATCH] Give the hunk comment its own color Bert Wesarg
2009-11-18 11:44 ` Tay Ray Chuan
2009-11-18 11:57 ` Bert Wesarg
2009-11-18 14:23 ` Jeff King
2009-11-18 15:16 ` Bert Wesarg
2009-11-18 21:56 ` Junio C Hamano
2009-11-18 22:44 ` Jeff King
2009-11-26 12:05 ` Bert Wesarg
2009-11-27 2:38 ` Junio C Hamano
2009-11-27 6:29 ` Bert Wesarg
2009-11-27 6:52 ` Jeff King
2009-11-27 7:27 ` Junio C Hamano
2009-11-27 6:55 ` [PATCH v3] " Bert Wesarg
2009-11-27 8:38 ` Junio C Hamano
2009-11-27 8:44 ` Bert Wesarg [this message]
2009-11-27 8:59 ` Junio C Hamano
2009-11-28 5:52 ` Junio C Hamano
2009-11-28 12:08 ` Bert Wesarg
2009-11-30 7:07 ` Bert Wesarg
2009-11-30 7:15 ` Junio C Hamano
2009-11-30 7:41 ` Bert Wesarg
2009-11-30 7:47 ` Junio C Hamano
2009-11-30 8:09 ` Sverre Rabbelier
2009-11-30 9:00 ` Junio C Hamano
2009-11-30 9:26 ` Sverre Rabbelier
2009-11-18 15:11 ` [PATCH v2] " Bert Wesarg
2009-11-18 15:17 ` Jason Sewall
2009-11-18 15:20 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36ca99e90911270044o68375902l3a0d2a4afa726a91@mail.gmail.com \
--to=bert.wesarg@googlemail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).