From: Bert Wesarg <bert.wesarg@googlemail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Jay Soffian <jaysoffian@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] get_ref_states: strdup entries and free util in stale list
Date: Tue, 1 Dec 2009 19:14:30 +0100 [thread overview]
Message-ID: <36ca99e90912011014sd7372d0yc234873a26c2ae43@mail.gmail.com> (raw)
In-Reply-To: <7v8wdm1ui1.fsf@alter.siamese.dyndns.org>
On Tue, Dec 1, 2009 at 18:20, Junio C Hamano <gitster@pobox.com> wrote:
> Bert Wesarg <bert.wesarg@googlemail.com> writes:
>
>>> - The ref abbrev_branch() is called and the address of whose substring is
>>> taken to be used as "name" in handle_one_branch() is refspec.src, but
>>> what goes to .util is refname that is refspec.dst---they are different
>>> strings and one is not a substring of the other.
>> I don't see you point here.
>
> Of course you don't ;-) because we were looking at different versions.
>
> I wanted to apply the same fix to both maint and master. For the code in
> 'master' your observation is 100% correct.
A quick test with my use case does not show errors in the maint
branch. So it should not be needed (except the memory leak fix of the
.util member). And valgrind confirms this.
Bert
>
next prev parent reply other threads:[~2009-12-01 18:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 23:57 [PATCH] get_ref_states: strdup entries and free util in stale list Bert Wesarg
2009-12-01 0:21 ` Junio C Hamano
2009-12-01 6:49 ` Bert Wesarg
2009-12-01 7:34 ` Junio C Hamano
2009-12-01 9:32 ` Bert Wesarg
2009-12-01 17:20 ` Junio C Hamano
2009-12-01 18:14 ` Bert Wesarg [this message]
2009-12-01 19:20 ` Junio C Hamano
2009-12-01 8:35 ` Johannes Schindelin
2009-12-01 9:05 ` Bert Wesarg
2009-12-01 15:53 ` Bert Wesarg
2009-12-01 18:20 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36ca99e90912011014sd7372d0yc234873a26c2ae43@mail.gmail.com \
--to=bert.wesarg@googlemail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jaysoffian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).