From: Bert Wesarg <bert.wesarg@googlemail.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Jay Soffian <jaysoffian@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] get_ref_states: strdup entries and free util in stale list
Date: Tue, 1 Dec 2009 19:20:55 +0100 [thread overview]
Message-ID: <36ca99e90912011020u4bcc8802qd12049969d162c97@mail.gmail.com> (raw)
In-Reply-To: <36ca99e90912010105r428a7bfdw63928e8a5515bd1d@mail.gmail.com>
On Tue, Dec 1, 2009 at 10:05, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
> There are still invalid reads of size 4. I think the problem is the
> flex array member of 'struct ref' and strlen(). If its worth I can
> look into this.
A short heads-up, here is the valgrind error I get for this invalid read:
==27305== Invalid read of size 4
==27305== at 0x4936AF: copy_ref (remote.c:870)
==27305== by 0x4942E4: get_fetch_map (remote.c:1271)
==27305== by 0x44473E: get_remote_ref_states (builtin-remote.c:271)
==27305== by 0x446DCE: cmd_remote (builtin-remote.c:1022)
==27305== by 0x4045F0: handle_internal_command (git.c:257)
==27305== by 0x404B8F: main (git.c:482)
==27305== Address 0x5b5ba38 is 104 bytes inside a block of size 107 alloc'd
==27305== at 0x4C24477: calloc (vg_replace_malloc.c:418)
==27305== by 0x4B09AD: xcalloc (wrapper.c:75)
==27305== by 0x493924: alloc_ref_with_prefix (remote.c:853)
==27305== by 0x46653B: get_remote_heads (connect.c:96)
==27305== by 0x4A9347: get_refs_via_connect (transport.c:453)
==27305== by 0x4A7F14: transport_get_remote_refs (transport.c:895)
==27305== by 0x4445B6: get_remote_ref_states (builtin-remote.c:810)
==27305== by 0x446DCE: cmd_remote (builtin-remote.c:1022)
==27305== by 0x4045F0: handle_internal_command (git.c:257)
==27305== by 0x404B8F: main (git.c:482)
prev parent reply other threads:[~2009-12-01 18:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-30 23:57 [PATCH] get_ref_states: strdup entries and free util in stale list Bert Wesarg
2009-12-01 0:21 ` Junio C Hamano
2009-12-01 6:49 ` Bert Wesarg
2009-12-01 7:34 ` Junio C Hamano
2009-12-01 9:32 ` Bert Wesarg
2009-12-01 17:20 ` Junio C Hamano
2009-12-01 18:14 ` Bert Wesarg
2009-12-01 19:20 ` Junio C Hamano
2009-12-01 8:35 ` Johannes Schindelin
2009-12-01 9:05 ` Bert Wesarg
2009-12-01 15:53 ` Bert Wesarg
2009-12-01 18:20 ` Bert Wesarg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=36ca99e90912011020u4bcc8802qd12049969d162c97@mail.gmail.com \
--to=bert.wesarg@googlemail.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jaysoffian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).