git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Dmitry Potapov" <dpotapov@gmail.com>
To: "Linus Torvalds" <torvalds@linux-foundation.org>
Cc: "Sam Ravnborg" <sam@ravnborg.org>,
	"Pierre Habouzit" <madcoder@debian.org>,
	"Junio C Hamano" <gitster@pobox.com>,
	git@vger.kernel.org, "Bernt Hansen" <bernt@alumni.uwaterloo.ca>
Subject: Re: [AGGREGATED PATCH] Fix in-place editing functions in convert.c
Date: Fri, 5 Oct 2007 23:27:55 +0400	[thread overview]
Message-ID: <37fcd2780710051227n96d29a9v543831ca8292c862@mail.gmail.com> (raw)
In-Reply-To: <alpine.LFD.0.999.0710051036282.23684@woody.linux-foundation.org>

On 10/5/07, Linus Torvalds <torvalds@linux-foundation.org> wrote:
>  - Qt (QString): QString::"data()", "ascii()" or "utf8()" or something.
>
>    At least this has the excuse of really being able to handle different
>    locales (it didn't do that originally, though!), but they end up having
>    a million helper functions exactly because you cannot use the normal
>    string routines on anything!

I am afraid you cannot allow the direct access to the internal buffer of
a string if this buffer can be implicitly shared between different
instances as it is the case with QString. Because when you want to make
some modification or want to get a non-const pointer to this buffer, its
content has to be copied if the buffer is shared between a few copies.

On the other hand, I don't see what is the problem with using C string
routines with it. ::data() returns a pointer and :capacity () returns
allocated size of the buffer. ::resize() changes the size of the string.
If you need a greater allocated size, you can use ::reserve().
Or did I miss something?

Dmitry

  reply	other threads:[~2007-10-05 19:28 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87wsu2sad0.fsf@gollum.intra.norang.ca>
2007-10-05  8:20 ` [PATCH] Fix in-place editing in crlf_to_git and ident_to_git Pierre Habouzit
2007-10-05  8:11   ` [AGGREGATED PATCH] Fix in-place editing functions in convert.c Pierre Habouzit
2007-10-05  9:24     ` Johannes Sixt
2007-10-05 13:07     ` Bernt Hansen
2007-10-05 15:26     ` Linus Torvalds
2007-10-05 15:50       ` Pierre Habouzit
2007-10-05 16:21       ` Sam Ravnborg
2007-10-05 16:35         ` Pierre Habouzit
2007-10-05 17:25           ` Sam Ravnborg
2007-10-05 16:43         ` Linus Torvalds
2007-10-05 17:24           ` Sam Ravnborg
2007-10-05 18:05             ` Linus Torvalds
2007-10-05 19:27               ` Dmitry Potapov [this message]
2007-10-05 19:33                 ` Linus Torvalds
2007-10-05  8:27   ` [PATCH] Fix memory leak in apply_filter Pierre Habouzit
2007-10-05  8:29   ` Pierre Habouzit
2007-10-05  8:30   ` [PATCH] Fix in-place editing in crlf_to_git and ident_to_git Johannes Schindelin
2007-10-05  8:40     ` Pierre Habouzit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=37fcd2780710051227n96d29a9v543831ca8292c862@mail.gmail.com \
    --to=dpotapov@gmail.com \
    --cc=bernt@alumni.uwaterloo.ca \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=madcoder@debian.org \
    --cc=sam@ravnborg.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).