From: Erik Chen <erikchen@chromium.org>
To: Junio C Hamano <gitster@pobox.com>,
Erik Chen via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v3 1/1] fetch: add trace2 instrumentation
Date: Tue, 19 Nov 2019 13:47:26 -0800 [thread overview]
Message-ID: <383762c9-06eb-707c-c0d8-c8ec8757133e@chromium.org> (raw)
In-Reply-To: <xmqq5zjws12y.fsf@gitster-ct.c.googlers.com>
Importing response from
https://github.com/gitgitgadget/git/pull/451#issuecomment-555044068
>
> /*
> * We write our multi-line comments like this, with the
> * slash-asterisk at the beginning and the asterisk-slash
> * at the end on its own line. Learn such local conventions
> * from the existing surrounding code and imitate, which
> * would reduce stylistic errors.
> */
>
> Will fix-up while queuing (no need to reroll only to fix this).
Sorry about that. I was copying from line 682, which looks like it was
also using the wrong style. I've fixed that line as well.
> So this introduces a single region around the entire function body
> of mark_complete_and_common_ref(), within which only one subpart is
> also enclosed in a nested region. Is that because the parts inside
> the outer region before and after the inner region are known to
> consume negligible time? IOW I would understand
Good point. I used this structure because I observed locally that the
middle block was slow, but was concerned that the initial/ending block
might be slow as well. I've gone ahead and adding tracing regions for
each block.
next prev parent reply other threads:[~2019-11-19 21:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 19:26 [PATCH 0/1] fetch: add trace2 instrumentation erik chen via GitGitGadget
2019-11-05 19:26 ` [PATCH 1/1] " Erik Chen via GitGitGadget
2019-11-06 12:30 ` Johannes Schindelin
2019-11-06 18:51 ` [PATCH v2 0/2] " erik chen via GitGitGadget
2019-11-06 18:51 ` [PATCH v2 1/2] " Erik Chen via GitGitGadget
2019-11-06 18:51 ` [PATCH v2 2/2] add whitespace Erik Chen via GitGitGadget
2019-11-06 19:39 ` [PATCH v3 0/1] fetch: add trace2 instrumentation erik chen via GitGitGadget
2019-11-06 19:39 ` [PATCH v3 1/1] " Erik Chen via GitGitGadget
2019-11-07 5:32 ` Junio C Hamano
2019-11-18 15:46 ` Derrick Stolee
2019-11-19 1:55 ` Junio C Hamano
2019-11-19 21:24 ` Erik Chen
2019-11-19 22:57 ` Erik Chen
2019-11-19 21:51 ` Erik Chen
2019-11-19 21:47 ` Erik Chen [this message]
2019-11-07 5:21 ` [PATCH v3 0/1] " Junio C Hamano
2019-11-19 21:44 ` Erik Chen
2019-11-18 14:52 ` [PATCH v4 " erik chen via GitGitGadget
2019-11-18 14:52 ` [PATCH v4 1/1] " Erik Chen via GitGitGadget
2019-11-19 23:02 ` [PATCH v5 0/1] " erik chen via GitGitGadget
2019-11-19 23:02 ` [PATCH v5 1/1] " Erik Chen via GitGitGadget
2019-11-20 1:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=383762c9-06eb-707c-c0d8-c8ec8757133e@chromium.org \
--to=erikchen@chromium.org \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).