From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09971C7EE2E for ; Mon, 12 Jun 2023 17:06:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232809AbjFLRGm (ORCPT ); Mon, 12 Jun 2023 13:06:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52272 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235011AbjFLRGk (ORCPT ); Mon, 12 Jun 2023 13:06:40 -0400 X-Greylist: delayed 460 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Mon, 12 Jun 2023 10:06:33 PDT Received: from rivendell.linuxfromscratch.org (rivendell.linuxfromscratch.org [208.118.68.85]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 1E50DE0 for ; Mon, 12 Jun 2023 10:06:32 -0700 (PDT) Received: from [10.0.0.30] (c-73-176-141-156.hsd1.il.comcast.net [73.176.141.156]) by rivendell.linuxfromscratch.org (Postfix) with ESMTPSA id F02F71C1D66 for ; Mon, 12 Jun 2023 16:58:47 +0000 (GMT) X-Virus-Status: Clean X-Virus-Scanned: clamav-milter 1.0.0 at rivendell.linuxfromscratch.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfromscratch.org; s=cert4; t=1686589128; bh=hE80X7bPD2ATp6P24wcdB9IFRZ7EiSnizGanSE7tNRY=; h=Date:To:From:Subject; b=EjMsSPDtQfluw+/XbHxFlYgYOqnV5bs7EI+7FRajFGonp+QQIfV0OnmYLXQERiyLU Kalfp24thksERPMIBg/Ae2Op2PONanOccn1lh4nXFwed9owfKv0DeOSZ46pwZCmsh0 FGXZFbxpQ0hLDggjJnxlU+FtKWJ0ZIKzKaJXRMVzz0MV7wCa6URaWl3799dn39+Zai hvLXH+I5bDeeepCf/o6VT6eA8fDIiJFr7lOfS5Pi4/rt3bhOdSmQQjGWku+B8b++be aFUQwQsxBPAGLswr8Xlm4k6/mPa94mmmxLnUlhRgM2fL///jAN4sP4n2cMQb876RUS xOaq7ZWqHYONw== Message-ID: <3843d97f-0073-e2d4-b98d-5a38c33b25f3@linuxfromscratch.org> Date: Mon, 12 Jun 2023 11:58:45 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: git@vger.kernel.org From: "Douglas R. Reno" Subject: Test failures with cURL-8.1.2 (when building git-2.41.0) Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Good afternoon, While building git-2.41.0 with curl-8.1.2 installed, I've noticed three test failures. They appear to be coming from t5559-http-fetch-smart-http2.sh. Here are the details from the tests: not ok 17 - GIT_TRACE_CURL redacts auth details # #               rm -rf redact-auth trace && #               set_askpass user@host pass@host && #               GIT_TRACE_CURL="$(pwd)/trace" git clone --bare "$HTTPD_URL/auth/smart/repo.git" redact-auth && #               expect_askpass both user@host && # #               # Ensure that there is no "Basic" followed by a base64 string, but that #               # the auth details are redacted #               ! grep -i "Authorization: Basic [0-9a-zA-Z+/]" trace && #               grep -i "Authorization: Basic " trace # not ok 18 - GIT_CURL_VERBOSE redacts auth details # #               rm -rf redact-auth trace && #               set_askpass user@host pass@host && #               GIT_CURL_VERBOSE=1 git clone --bare "$HTTPD_URL/auth/smart/repo.git" redact-auth 2>trace && #               expect_askpass both user@host && # #               # Ensure that there is no "Basic" followed by a base64 string, but that #               # the auth details are redacted #               ! grep -i "Authorization: Basic [0-9a-zA-Z+/]" trace && #               grep -i "Authorization: Basic " trace # ok 19 - GIT_TRACE_CURL does not redact auth details if GIT_TRACE_REDACT=0 ok 20 - disable dumb http on server ok 21 - GIT_SMART_HTTP can disable smart http ok 22 - invalid Content-Type rejected ok 23 - create namespaced refs ok 24 - smart clone respects namespace ok 25 - dumb clone via http-backend respects namespace ok 26 - cookies stored in http.cookiefile when http.savecookies set ok 27 - transfer.hiderefs works over smart-http ok 28 - create 2,000 tags in the repo ok 29 - clone the 2,000 tag repo to check OS command line overflow ok 30 - large fetch-pack requests can be sent using chunked encoding ok 31 - test allowreachablesha1inwant ok 32 - test allowreachablesha1inwant with unreachable ok 33 - test allowanysha1inwant with unreachable ok 34 # skip http can handle enormous ref negotiation (missing EXPENSIVE) ok 35 - custom http headers ok 36 - using fetch command in remote-curl updates refs ok 37 - fetch by SHA-1 without tag following not ok 38 - cookies are redacted by default # #               rm -rf clone && #               echo "Set-Cookie: Foo=1" >cookies && #               echo "Set-Cookie: Bar=2" >>cookies && #               GIT_TRACE_CURL=true \ #                       git -c "http.cookieFile=$(pwd)/cookies" clone \ #                       $HTTPD_URL/smart/repo.git clone 2>err && #               grep -i "Cookie:.*Foo=" err && #               grep -i "Cookie:.*Bar=" err && #               ! grep -i "Cookie:.*Foo=1" err && #               ! grep -i "Cookie:.*Bar=2" err # I've done a bit of investigation and found the directory where it's saving the results to, "trash directory.t5559-http-fetch-smart-http2". After changing to that directory and running 'grep -i "Authorization: Basic"' trace, I get: renodr [ /sources/git-2.41.0/git-2.41.0/t/trash directory.t5559-http-fetch-smart-http2 ]$ grep -i "Authorization: Basic" trace == Info: h2 [authorization: Basic dXNlckBob3N0OnBhc3NAaG9zdA==] => Send header: Authorization: Basic dXNlckBob3N0OnBhc3NAaG9zdA== == Info: h2 [authorization: Basic dXNlckBob3N0OnBhc3NAaG9zdA==] => Send header: Authorization: Basic dXNlckBob3N0OnBhc3NAaG9zdA== == Info: h2 [authorization: Basic dXNlckBob3N0OnBhc3NAaG9zdA==] => Send header: Authorization: Basic dXNlckBob3N0OnBhc3NAaG9zdA== Checking the 'err' file where the cookies test was supposed to be looking in results in: renodr [ /sources/git-2.41.0/git-2.41.0/t/trash directory.t5559-http-fetch-smart-http2 ]$ cat err fatal: URL 'https://user%40host:@127.0.0.1:5559/auth/smart/repo.git' uses plaintext credentials Please let me know if there's any way that I can help diagnose this further! Thank you, - Doug