From: Fabio Augusto Dal Castel <fdcastel@gmail.com>
To: Matthieu Moy <Matthieu.Moy@imag.fr>
Cc: Jeff King <peff@peff.net>, Brandon Casey <casey@nrlssc.navy.mil>,
git@vger.kernel.org
Subject: Re: [RFC] New command: 'git snapshot'.
Date: Wed, 11 Feb 2009 18:40:15 -0200 [thread overview]
Message-ID: <38cfbb550902111240v6e593bfw5c8347d92fe8f767@mail.gmail.com> (raw)
In-Reply-To: <vpq3aelcpjk.fsf@bauges.imag.fr>
> Doesn't that argue for "git stash --no-reset" or similar instead of a
> separate command?
Yes. And also for an "--untracked" (as already suggested).
Since stashes does not expire anymore (as correctly pointed by
Brandon), a snapshot could be reduced to an alias for:
git stash --no-reset --untracked
(except for the branch storage)
However, the rationale behind a new command was also to avoid the
'loss of identity' of stash (as currently implemented). I always saw
stash as a way to allow a temporary hack or a pull. If we start adding
a lot of switches into stash that ultimately would change its main
purpose, should it yet be called 'stash'? (something like a 'git
commit --no-commit' ?)
(Please, don't get me wrong: I'm just raising food for thoughts, here)
Maybe the 'stash' command and multiples switches would be more
appropriate if 'reset' was NOT the default behavior. Something like:
git stash [--untracked] [--reset]
where the current 'git stash' would be 'git stash --reset'.Of course,
this would be a significant breaking change.
I know... I know... "Heresy!" You'd say... <g>
But... what about it? Why, after all, stash MUST do a reset?
"Do one thing. Do it well"?
Regards!
Fabio.
next prev parent reply other threads:[~2009-02-11 20:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-09 18:54 [RFC] New command: 'git snapshot' Fabio Augusto Dal Castel
2009-02-09 19:52 ` Giuseppe Bilotta
[not found] ` <38cfbb550902101232l4c83b6dfjc70e1e2f79a8c3c1@mail.gmail.com>
2009-02-10 20:48 ` Fabio Augusto Dal Castel
2009-02-09 22:36 ` Brandon Casey
2009-02-10 4:51 ` Sitaram Chamarty
2009-02-10 19:47 ` Jon Loeliger
2009-02-10 20:31 ` Junio C Hamano
2009-02-11 1:22 ` Sitaram Chamarty
2009-02-10 20:40 ` Fabio Augusto Dal Castel
2009-02-10 23:00 ` Jeff King
2009-02-10 23:08 ` Junio C Hamano
2009-02-10 23:38 ` Jeff King
2009-02-10 23:39 ` Geoffrey Lee
2009-02-11 13:43 ` Jeff King
2009-02-11 9:04 ` Matthieu Moy
2009-02-11 20:40 ` Fabio Augusto Dal Castel [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-02-10 23:58 Ulrik Sverdrup
2009-02-11 0:05 ` Ulrik Sverdrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=38cfbb550902111240v6e593bfw5c8347d92fe8f767@mail.gmail.com \
--to=fdcastel@gmail.com \
--cc=Matthieu.Moy@imag.fr \
--cc=casey@nrlssc.navy.mil \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).