From: drafnel@gmail.com
To: gitster@pobox.com
Cc: git@vger.kernel.org, Brandon Casey <drafnel@gmail.com>
Subject: [PATCH] builtin-clone.c: Need to closedir() in copy_or_link_directory()
Date: Sat, 17 May 2008 23:00:01 -0500 [thread overview]
Message-ID: <3926741.1211083121329.JavaMail.teamon@b306.teamon.com> (raw)
In-Reply-To: <1211083201-2696-1-git-send-email-foo@example.com>
From: Brandon Casey <drafnel@gmail.com>
So not to leak file descriptors, close the directory after opening it.
Signed-off-by: Brandon Casey <drafnel@gmail.com>
---
builtin-clone.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/builtin-clone.c b/builtin-clone.c
index 8713128..8936a51 100644
--- a/builtin-clone.c
+++ b/builtin-clone.c
@@ -215,6 +215,7 @@ static void copy_or_link_directory(char *src, char *dest)
die("failed to create link %s\n", dest);
}
}
+ closedir(dir);
}
static const struct ref *clone_local(const char *src_repo,
--
1.5.5.1.447.geb0a7
parent reply other threads:[~2008-05-18 3:59 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <1211083201-2696-1-git-send-email-foo@example.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3926741.1211083121329.JavaMail.teamon@b306.teamon.com \
--to=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).