running git as root

running git as root

[Marco Nelissen]

When running as root, git fails a number of test cases that expect it
to fail on read-only repositories (for example 't0004-unwritable.sh').
I was thinking of either changing the code so that it checks
permissions itself when opening files as root, or add a prerequisite
to those test cases so that they are skipped when running as root.
What would be the preferred way?

Re: running git as root

[Michael J Gruber]

Marco Nelissen venit, vidit, dixit 13.06.2009 17:25:
> When running as root, git fails a number of test cases that expect it
> to fail on read-only repositories (for example 't0004-unwritable.sh').
> I was thinking of either changing the code so that it checks
> permissions itself when opening files as root, or add a prerequisite
> to those test cases so that they are skipped when running as root.
> What would be the preferred way?

The preferred ways is to build git as non-root user. This is true even
more so for running the test suite.

Michael

Re: running git as root

[Alex Riesen]

2009/6/13 Marco Nelissen <marcone@xs4all.nl>:
> When running as root, git fails a number of test cases that expect it
> to fail on read-only repositories (for example 't0004-unwritable.sh').
> I was thinking of either changing the code so that it checks
> permissions itself when opening files as root, or add a prerequisite
> to those test cases so that they are skipped when running as root.

There is such a prerequisite already (POSIXPERM), but what caused
you to run the _tests_ as root?

> What would be the preferred way?

Use the prerequisite would sound right when not the
strangeness of the idea.

Re: running git as root

[Marco Nelissen]

On Sat, Jun 13, 2009 at 10:49 AM, Alex Riesen<raa.lkml@gmail.com> wrote:
> 2009/6/13 Marco Nelissen <marcone@xs4all.nl>:
>> When running as root, git fails a number of test cases that expect it
>> to fail on read-only repositories (for example 't0004-unwritable.sh').
>> I was thinking of either changing the code so that it checks
>> permissions itself when opening files as root, or add a prerequisite
>> to those test cases so that they are skipped when running as root.
>
> There is such a prerequisite already (POSIXPERM), but what caused
> you to run the _tests_ as root?

POSIXPERM doesn't appear to be quite right for this. For example, the
't1301-shared-repo.sh' test has the POSIXPERM prereq, but it runs fine
as root, because it merely validates that permissions are preserved.

Re: running git as root

[Marco Nelissen]

On Sat, Jun 13, 2009 at 8:42 AM, Michael J
Gruber<git@drmicha.warpmail.net> wrote:
> Marco Nelissen venit, vidit, dixit 13.06.2009 17:25:
>> When running as root, git fails a number of test cases that expect it
>> to fail on read-only repositories (for example 't0004-unwritable.sh').
>> I was thinking of either changing the code so that it checks
>> permissions itself when opening files as root, or add a prerequisite
>> to those test cases so that they are skipped when running as root.
>> What would be the preferred way?
>
> The preferred ways is to build git as non-root user. This is true even
> more so for running the test suite.

This is not possible on BeOS, where there is only one user, and it is
the super user.

Re: running git as root

[Nanako Shiraishi]

Quoting Alex Riesen <raa.lkml@gmail.com>:

> 2009/6/13 Marco Nelissen <marcone@xs4all.nl>:
>> When running as root, git fails a number of test cases that expect it
>> to fail on read-only repositories (for example 't0004-unwritable.sh').
>> I was thinking of either changing the code so that it checks
>> permissions itself when opening files as root, or add a prerequisite
>> to those test cases so that they are skipped when running as root.
>
> There is such a prerequisite already (POSIXPERM), but what caused
> you to run the _tests_ as root?
>
>> What would be the preferred way?
>
> Use the prerequisite would sound right when not the
> strangeness of the idea.

I think somebody needs to repost an old patch from the archive.

    http://thread.gmane.org/gmane.comp.version-control.git/116729/focus=118385

-- 
Nanako Shiraishi
http://ivory.ap.teacup.com/nanako3/

Re: running git as root

[Marco Nelissen]

On Sat, Jun 13, 2009 at 11:08 PM, Nanako Shiraishi<nanako3@lavabit.com> wrote:
> Quoting Alex Riesen <raa.lkml@gmail.com>:
>
>> 2009/6/13 Marco Nelissen <marcone@xs4all.nl>:
>>> When running as root, git fails a number of test cases that expect it
>>> to fail on read-only repositories (for example 't0004-unwritable.sh').
>>> I was thinking of either changing the code so that it checks
>>> permissions itself when opening files as root, or add a prerequisite
>>> to those test cases so that they are skipped when running as root.
>>
>> There is such a prerequisite already (POSIXPERM), but what caused
>> you to run the _tests_ as root?
>>
>>> What would be the preferred way?
>>
>> Use the prerequisite would sound right when not the
>> strangeness of the idea.
>
> I think somebody needs to repost an old patch from the archive.
>
>    http://thread.gmane.org/gmane.comp.version-control.git/116729/focus=118385

That's almost identical to the patch I wanted to submit, except for
the name 'SANITY', which doesn't make much sense I think.