From: Vladimir Panteleev <thecybershadow@gmail.com>
To: Junio C Hamano <gitster@pobox.com>,
Vladimir Panteleev <git@thecybershadow.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] show-ref: Allow --head to work with --verify
Date: Fri, 20 Jan 2017 22:55:12 +0000 [thread overview]
Message-ID: <3b1d2717-dd7f-2add-b935-3ace6063b258@gmail.com> (raw)
In-Reply-To: <xmqqa8aly2o4.fsf@gitster.mtv.corp.google.com>
On 2017-01-20 19:03, Junio C Hamano wrote:
> and viewed in the wider context, I notice that quiet is not honored
> in the added code. I think that is easily fixable by replacing this
> hunk with something like:
--quiet will still work correctly with the current patch, because
show_ref already checks quiet. Granted, the original --verify code used
show_one and not show_ref; however, I don't see a meaningful difference
between calling show_ref and show_one for HEAD, other than a bit of
overhead, so adding a new function may not be worthwhile. I will still
add tests for this; however, in light of this, would you still like me
to perform the change you requested?
--
Best regards,
Vladimir
next prev parent reply other threads:[~2017-01-20 22:55 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-20 15:50 [PATCH] show-ref: Allow --head to work with --verify Vladimir Panteleev
2017-01-20 19:03 ` Junio C Hamano
2017-01-20 20:26 ` Vladimir Panteleev
2017-01-20 20:51 ` Vladimir Panteleev
2017-01-20 22:22 ` Junio C Hamano
2017-01-20 22:31 ` Junio C Hamano
2017-01-20 23:15 ` Junio C Hamano
2017-01-20 22:55 ` Vladimir Panteleev [this message]
2017-01-20 23:20 ` Junio C Hamano
2017-01-20 23:29 ` Junio C Hamano
2017-01-21 0:25 ` Vladimir Panteleev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b1d2717-dd7f-2add-b935-3ace6063b258@gmail.com \
--to=thecybershadow@gmail.com \
--cc=git@thecybershadow.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).