git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel <mjucde@o2.pl>
To: git@vger.kernel.org, "Stephen Boyd" <bebarino@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH] commit-tree: remove unused #define
Date: Mon, 25 Jan 2010 10:17:50 +0100	[thread overview]
Message-ID: <3b96b7e4.67f13727.4b5d61be.1391c@o2.pl> (raw)
In-Reply-To: <1264403143-11320-1-git-send-email-bebarino@gmail.com>

> ---
> 
> The fixme looks very suspicious too...

According to git blame it belongs to the same revision as BLOCKING
 -- initial commit. So probably it can be removed with BLOCKING.

> 
>  builtin-commit-tree.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/builtin-commit-tree.c b/builtin-commit-tree.c
> index ddcb7a4..90dac34 100644
> --- a/builtin-commit-tree.c
> +++ b/builtin-commit-tree.c
> @@ -9,8 +9,6 @@
>  #include "builtin.h"
>  #include "utf8.h"
>  
> -#define BLOCKING (1ul << 14)
> -
>  /*
>   * FIXME! Share the code with "write-tree.c"
>   */
> -- 
> 1.6.6.1.436.gaba7d
> 

-- Daniel

      reply	other threads:[~2010-01-25  9:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-25  7:05 [PATCH] commit-tree: remove unused #define Stephen Boyd
2010-01-25  9:17 ` Daniel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3b96b7e4.67f13727.4b5d61be.1391c@o2.pl \
    --to=mjucde@o2.pl \
    --cc=bebarino@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).