From: Thomas Rast <tr@thomasrast.ch>
To: git@vger.kernel.org
Cc: Ramkumar Ramachandra <artagnon@gmail.com>
Subject: [PATCH 1/3] send-email: pass Debug to Net::SMTP::SSL::new
Date: Sun, 1 Dec 2013 23:48:41 +0100 [thread overview]
Message-ID: <3bb0c80c70e1c40236034552bec037cb0c26167c.1385938050.git.tr@thomasrast.ch> (raw)
We forgot to pass the Debug option through to Net::SMTP::SSL->new --
which is the same as Net::SMTP->new. This meant that with security
set to SSL, we would never enable debug output.
Pass through the flag.
Signed-off-by: Thomas Rast <tr@thomasrast.ch>
---
git-send-email.perl | 1 +
1 file changed, 1 insertion(+)
diff --git a/git-send-email.perl b/git-send-email.perl
index 3782c3b..f7468b6 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1217,6 +1217,7 @@ sub send_message {
$smtp ||= Net::SMTP::SSL->new($smtp_server,
Hello => $smtp_domain,
Port => $smtp_server_port,
+ Debug => $debug_net_smtp,
ssl_verify_params());
}
else {
--
1.8.5.rc3.5.g2a1fe2f
next reply other threads:[~2013-12-01 22:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-01 22:48 Thomas Rast [this message]
2013-12-01 22:48 ` [PATCH 2/3] send-email: --smtp-ssl-cert-path takes an argument Thomas Rast
2013-12-01 22:48 ` [PATCH 3/3] send-email: set SSL options through IO::Socket::SSL::set_client_defaults Thomas Rast
2013-12-02 10:44 ` Ramkumar Ramachandra
2013-12-02 23:23 ` Thomas Rast
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3bb0c80c70e1c40236034552bec037cb0c26167c.1385938050.git.tr@thomasrast.ch \
--to=tr@thomasrast.ch \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).