git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: jbialobr <jbialobr@o2.pl>
To: git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>
Cc: gitster@pobox.com, msysgit@googlegroups.com
Subject: Re: Re: Re: Re: File path not escaped in warning message
Date: Tue, 07 Aug 2012 10:20:23 +0200	[thread overview]
Message-ID: <3bc6610e.6355e5e2.5020cfc7.c1687@o2.pl> (raw)
In-Reply-To: <OF9C260C14.7F8DC09D-ONC1257A52.005D3AD5-C1257A52.005F222E@dcon.de>

Hi Karsten,

Thanks, you helped me a lot. I see now, that logoutputencoding 
is for commit header data, not for whole log output. The name
is little missleading, so do description:
i18n.logOutputEncoding
   Encoding to use when displaying logs.

Regarding git-log / git-diff output, there are basically three different

character set encodings involved:
1. commit log messages: re-coded to i18n.logoutputencoding (usually
UTF-8)

also commiter and author fields.

2. file content: printed verbatim (no re-coding); gui tools such as gitk

may decode this based on gui.encoding or .gitattributes settings
3. everything else (file names, diff headers, error / warning messages):

always UTF-8 (at least in Git for Windows)

It is more like git encoding than UTF-8. 


Gui tools such as gitk decode this output line by line using the 
appropriate encoding.

It would be easier to do it if output was displayed in consistent way. I
see no reason why one part of output is quoted and other is not. Another
example:

$ git status
warning: LF will be replaced by CRLF in 1ą.txt.
The file will have its original line endings in your working directory.
# On branch master
# Your branch and 'origin/master' have diverged,
# and have 2 and 2 different commit(s) each, respectively.
#
# Changes to be committed:
#   (use "git reset HEAD <file>..." to unstage)
#
#       modified:   "1\261.txt"
#

Git doesn't recode commit header when --pretty is set to format,
but recodes when --pretty is set to full, raw, etc. Do you know if it is
done by mistake or by design?

Thanks again,
Janusz Białobrzewski.


-- 
*** Please reply-to-all at all times ***
*** (do not pretend to know who is subscribed and who is not) ***
*** Please avoid top-posting. ***
The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free.

You received this message because you are subscribed to the Google
Groups "msysGit" group.
To post to this group, send email to msysgit@googlegroups.com
To unsubscribe from this group, send email to
msysgit+unsubscribe@googlegroups.com
For more options, and view previous threads, visit this group at
http://groups.google.com/group/msysgit?hl=en_US?hl=en

      reply	other threads:[~2012-08-07  8:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-04 12:55 File path not escaped in warning message Janusz Białobrzewski
2012-08-04 22:20 ` Junio C Hamano
2012-08-05 12:05   ` Janusz Białobrzewski
2012-08-05 19:48     ` Junio C Hamano
2012-08-06  6:53       ` jbialobr
2012-08-06 17:18         ` karsten.blees
2012-08-07  8:20           ` jbialobr [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3bc6610e.6355e5e2.5020cfc7.c1687@o2.pl \
    --to=jbialobr@o2.pl \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=msysgit@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).