From: Michael Witten <mfwitten@gmail.com>
To: git@vger.kernel.org
Subject: [RFC 3/3] Alternates API: Remove unused parameter
Date: Wed, 30 Mar 2011 21:28:11 +0000 [thread overview]
Message-ID: <3c357acd119aa836f6cd3298d62cc5098f4c053c.1301521244.git.mfwitten@gmail.com> (raw)
In-Reply-To: <cover.1301521243.git.mfwitten@gmail.com>
Signed-off-by: Michael Witten <mfwitten@gmail.com>
---
builtin/fetch-pack.c | 2 +-
builtin/receive-pack.c | 2 +-
transport.c | 2 +-
transport.h | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/transport.h b/transport.h
index 88fa484..cf6fda4 100644
--- a/transport.h
+++ b/transport.h
@@ -166,7 +166,7 @@ int transport_refs_pushed(struct ref *ref);
void transport_print_push_status(const char *dest, struct ref *refs,
int verbose, int porcelain, int *nonfastforward);
-typedef void (*transport_alt_refs_fn)(const struct ref *, void *);
+typedef void (*transport_alt_refs_fn)(const struct ref *);
extern int transport_alt_refs(struct alternate_object_database *, transport_alt_refs_fn);
#endif
diff --git a/transport.c b/transport.c
index 53d37a9..165f69e 100644
--- a/transport.c
+++ b/transport.c
@@ -1217,7 +1217,7 @@ int transport_alt_refs(struct alternate_object_database *d, transport_alt_refs_f
for (extra = transport_get_remote_refs(transport);
extra;
extra = extra->next)
- ref_fn(extra, NULL);
+ ref_fn(extra);
transport_disconnect(transport);
free(other);
return 0;
diff --git a/builtin/fetch-pack.c b/builtin/fetch-pack.c
index b3a9f74..d2e0111 100644
--- a/builtin/fetch-pack.c
+++ b/builtin/fetch-pack.c
@@ -219,7 +219,7 @@ static void send_request(int fd, struct strbuf *buf)
safe_write(fd, buf->buf, buf->len);
}
-static void insert_one_alternate_ref(const struct ref *ref, void *unused)
+static void insert_one_alternate_ref(const struct ref *ref)
{
rev_list_insert_ref(NULL, ref->old_sha1, 0, NULL);
}
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index a761332..47a5aaa 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -731,7 +731,7 @@ static int delete_only(struct command *commands)
return 1;
}
-static void add_one_alternate_ref(const struct ref *ref, void *unused)
+static void add_one_alternate_ref(const struct ref *ref)
{
add_extra_ref(".have", ref->old_sha1, 0);
}
--
1.7.4.18.g68fe8
next prev parent reply other threads:[~2011-03-30 22:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-29 15:28 [RFC 2/2] Future Proofing: Pass around pointers to either functions or data Michael Witten
2011-03-29 15:02 ` [RFC 1/2] Portability: Convert strictly between function pointers Michael Witten
2011-03-30 10:09 ` [RFC 2/2] Future Proofing: Pass around pointers to either functions or data Erik Faye-Lund
2011-03-30 15:02 ` Michael Witten
2011-03-30 19:41 ` Junio C Hamano
2011-03-30 21:40 ` [RFC 0/3] Alternates API Michael Witten
2011-03-30 21:24 ` [RFC 2/3] Alternates API: Improve naming Michael Witten
2011-03-30 21:28 ` Michael Witten [this message]
2011-03-30 20:43 ` [RFC 1/3] Alternates API: Untangle the interface Michael Witten
2011-03-30 22:28 ` Junio C Hamano
2011-03-30 22:46 ` [RFC 3/3] Alternates API: Remove unused parameter Junio C Hamano
2011-03-30 22:31 ` [RFC 2/3] Alternates API: Improve naming Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c357acd119aa836f6cd3298d62cc5098f4c053c.1301521244.git.mfwitten@gmail.com \
--to=mfwitten@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).