git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: public git mailing list <git@vger.kernel.org>
Subject: Re: "--quiet" for git-push does not suppress remote hook output
Date: Thu, 7 May 2020 14:16:36 +0200	[thread overview]
Message-ID: <3cb011a9-ce3d-df38-01c6-062062f1c9c2@redhat.com> (raw)
In-Reply-To: <ba70b25b-906c-0117-2594-c606595c6816@redhat.com>

(Sorry about the self-followup...)

On 05/07/20 14:05, Laszlo Ersek wrote:
> Hi,
> 
> being a total novice in git internals, it seems like
> "builtin/receive-pack.c" (on the server) forwards any receive hook
> output with copy_to_sideband() back to git-push (on the client), even if
> git-push was invoked with "--quiet".
> 
> And "case 2" in demultiplex_sideband() seems to print that "band" to
> stderr (on the client), despite "--quiet".
> 
> Is this intentional? I'd prefer "git push --quiet" to suppress remote
> hook output (unless the remote hook fails).

Or else:

would it be the job of the particular receive hooks to observe and obey
the "--quiet" option in the GIT_PUSH_OPTION_* environment variables?

Thanks!
Laszlo


  reply	other threads:[~2020-05-07 12:16 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-07 12:05 "--quiet" for git-push does not suppress remote hook output Laszlo Ersek
2020-05-07 12:16 ` Laszlo Ersek [this message]
2020-05-07 21:02   ` Jeff King
2020-05-08  9:50     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3cb011a9-ce3d-df38-01c6-062062f1c9c2@redhat.com \
    --to=lersek@redhat.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).