From: Phillip Wood <phillip.wood123@gmail.com>
To: Kristoffer Haugsbakk <code@khaugsbakk.name>, git@vger.kernel.org
Cc: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>,
newren@gmail.com
Subject: Re: [PATCH 0/3] doc: merge-tree: improve the script example
Date: Mon, 7 Oct 2024 15:59:04 +0100 [thread overview]
Message-ID: <3ce39bec-24e4-4850-b947-e6476fac5132@gmail.com> (raw)
In-Reply-To: <cover.1728298931.git.code@khaugsbakk.name>
Hi Kristoffer
Thanks for working on this. Patches 1 and 3 look like clear improvements
to me, I've left a comment on patch 2 as the improvement is less clear
to me but I wouldn't object to it being merged.
Best Wishes
Phillip
On 07/10/2024 12:10, Kristoffer Haugsbakk wrote:
> From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
>
>
> Kristoffer Haugsbakk (3):
> doc: merge-tree: provide a commit message
> doc: merge-tree: use lower-case variables
> doc: merge-tree: use || directly
>
> Documentation/git-merge-tree.txt | 14 ++++++++------
> 1 file changed, 8 insertions(+), 6 deletions(-)
>
> --
> 2.46.1.641.g54e7913fcb6
>
next prev parent reply other threads:[~2024-10-07 14:59 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-07 11:10 [PATCH 0/3] doc: merge-tree: improve the script example Kristoffer Haugsbakk
2024-10-07 11:10 ` [PATCH 1/3] doc: merge-tree: provide a commit message Kristoffer Haugsbakk
2024-10-07 12:02 ` Kristoffer Haugsbakk
2024-10-07 15:17 ` Elijah Newren
2024-10-07 15:23 ` Kristoffer Haugsbakk
2024-10-07 11:10 ` [PATCH 2/3] doc: merge-tree: use lower-case variables Kristoffer Haugsbakk
2024-10-07 14:58 ` Phillip Wood
2024-10-07 15:22 ` Elijah Newren
2024-10-07 11:10 ` [PATCH 3/3] doc: merge-tree: use || directly Kristoffer Haugsbakk
2024-10-07 15:24 ` Elijah Newren
2024-10-07 15:44 ` Kristoffer Haugsbakk
2024-10-07 14:59 ` Phillip Wood [this message]
2024-10-07 15:00 ` [PATCH 0/3] doc: merge-tree: improve the script example Kristoffer Haugsbakk
2024-10-08 19:06 ` [PATCH v2 0/2] " Kristoffer Haugsbakk
2024-10-08 19:06 ` [PATCH v2 1/2] doc: merge-tree: provide a commit message Kristoffer Haugsbakk
2024-10-08 20:42 ` Junio C Hamano
2024-10-08 20:44 ` Kristoffer Haugsbakk
2024-10-09 16:35 ` Kristoffer Haugsbakk
2024-10-09 17:38 ` Junio C Hamano
2024-10-09 16:58 ` Andreas Schwab
2024-10-08 19:06 ` [PATCH v2 2/2] doc: merge-tree: use || directly Kristoffer Haugsbakk
2024-10-08 20:44 ` Junio C Hamano
2024-10-08 20:48 ` Kristoffer Haugsbakk
2024-10-09 16:53 ` [PATCH v3 0/1] doc: merge-tree: improve the script example Kristoffer Haugsbakk
2024-10-09 16:53 ` [PATCH v3 1/1] doc: merge-tree: improve example script Kristoffer Haugsbakk
2024-10-09 20:50 ` [PATCH v3 0/1] doc: merge-tree: improve the script example Elijah Newren
2024-10-10 0:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3ce39bec-24e4-4850-b947-e6476fac5132@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=code@khaugsbakk.name \
--cc=git@vger.kernel.org \
--cc=kristofferhaugsbakk@fastmail.com \
--cc=newren@gmail.com \
--cc=phillip.wood@dunelm.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).