From: Phillip Wood <phillip.wood123@gmail.com>
To: Karthik Nayak <karthik.188@gmail.com>,
Phillip Wood <phillip.wood@dunelm.org.uk>,
git@vger.kernel.org
Cc: "René Scharfe" <l.s.r@web.de>,
"Brian M . Carlson" <sandals@crustytoothpaste.net>,
"Elijah Newren" <newren@gmail.com>,
"Eric Sunshine" <sunshine@sunshineco.com>,
"Jeff King" <peff@peff.net>
Subject: Re: [PATCH v3 0/3] C99: declare bool experiment a success
Date: Thu, 17 Jul 2025 16:21:12 +0100 [thread overview]
Message-ID: <3e799a41-fa68-4d22-8e8e-930fcab807f8@gmail.com> (raw)
In-Reply-To: <CAOLa=ZSk5O0sQRN5Yf+i6Jh2Dk_pafQhLYNY5eBp_S5y-HoC3w@mail.gmail.com>
Hi Karthik
On 16/07/2025 11:29, Karthik Nayak wrote:
> Phillip Wood <phillip.wood123@gmail.com> writes:
>
>> From: Phillip Wood <phillip.wood@dunelm.org.uk>
>>
>> We've had a test balloon for C99's bool type since 8277dbe987
>> (git-compat-util: convert skip_{prefix,suffix}{,_mem} to bool,
>> 2023-12-16). As it has been over 18 months since this was added and
>> there have been no complaints let's declare it a success and convert
>> the return type our other string predicates to match.
>>
>
> Neat, I didn't even know we were running such an experiment. Thanks for
> getting around to it, I think the patches look great, added some
> complaints from 'clang-format', feel free to ignore.
Thanks for taking a look. I would have fixed the formatting but this is
in next already so I'll leave it as it is if that's ok with you.
Thanks
Phillip
next prev parent reply other threads:[~2025-07-17 15:21 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 13:26 [PATCH 0/3] C99: declare bool experiment a success Phillip Wood
2025-07-14 13:27 ` [PATCH 1/3] CodingGuildlines: allow the use of bool Phillip Wood
2025-07-14 16:37 ` Junio C Hamano
2025-07-14 13:27 ` [PATCH 2/3] git-compat-util: convert string predicates to return bool Phillip Wood
2025-07-14 16:46 ` Eric Sunshine
2025-07-14 17:20 ` Elijah Newren
2025-07-14 21:14 ` brian m. carlson
2025-07-15 9:36 ` Phillip Wood
2025-07-14 13:27 ` [PATCH 3/3] strbuf: convert " Phillip Wood
2025-07-15 13:52 ` [PATCH v2 0/3] C99: declare bool experiment a success Phillip Wood
2025-07-15 13:52 ` [PATCH v2 1/3] CodingGuildlines: allow the use of bool Phillip Wood
2025-07-16 4:38 ` Jeff King
2025-07-16 4:46 ` Jeff King
2025-07-16 5:06 ` Elijah Newren
2025-07-15 13:52 ` [PATCH v2 2/3] git-compat-util: convert string predicates to return bool Phillip Wood
2025-07-15 13:52 ` [PATCH v2 3/3] strbuf: convert " Phillip Wood
2025-07-15 17:19 ` [PATCH v2 0/3] C99: declare bool experiment a success Elijah Newren
2025-07-15 18:23 ` rsbecker
2025-07-15 19:35 ` Elijah Newren
2025-07-15 20:47 ` rsbecker
2025-07-15 21:06 ` Junio C Hamano
2025-07-15 18:53 ` Junio C Hamano
2025-07-15 21:48 ` brian m. carlson
2025-07-15 22:09 ` Junio C Hamano
2025-07-16 9:38 ` [PATCH v3 " Phillip Wood
2025-07-16 9:38 ` [PATCH v3 1/3] CodingGuidelines: allow the use of bool Phillip Wood
2025-07-16 9:38 ` [PATCH v3 2/3] git-compat-util: convert string predicates to return bool Phillip Wood
2025-07-16 10:26 ` Karthik Nayak
2025-07-16 9:38 ` [PATCH v3 3/3] strbuf: convert " Phillip Wood
2025-07-16 10:28 ` Karthik Nayak
2025-07-16 10:29 ` [PATCH v3 0/3] C99: declare bool experiment a success Karthik Nayak
2025-07-17 15:21 ` Phillip Wood [this message]
2025-07-22 8:09 ` Karthik Nayak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3e799a41-fa68-4d22-8e8e-930fcab807f8@gmail.com \
--to=phillip.wood123@gmail.com \
--cc=git@vger.kernel.org \
--cc=karthik.188@gmail.com \
--cc=l.s.r@web.de \
--cc=newren@gmail.com \
--cc=peff@peff.net \
--cc=phillip.wood@dunelm.org.uk \
--cc=sandals@crustytoothpaste.net \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).